Re: [Xen-devel] [PATCH RFC 1/8] golang/xenlight: Create stub package

2017-01-27 Thread George Dunlap
On 23/01/17 16:43, Ronald Rojas wrote: > Create a basic Makefile to build and install libxenlight Golang > bindings. Also add a stub package which only opens libxl context. > > Include a global xenlight.Ctx variable which can be used as the > default context by the entire program if desired. > >

Re: [Xen-devel] [PATCH RFC 1/8] golang/xenlight: Create stub package

2017-01-27 Thread George Dunlap
On 23/01/17 16:43, Ronald Rojas wrote: > Create a basic Makefile to build and install libxenlight Golang > bindings. Also add a stub package which only opens libxl context. > > Include a global xenlight.Ctx variable which can be used as the > default context by the entire program if desired. > >

Re: [Xen-devel] [PATCH RFC 1/8] golang/xenlight: Create stub package

2017-01-26 Thread George Dunlap
On 26/01/17 10:44, Ian Jackson wrote: > George Dunlap writes ("Re: [Xen-devel] [PATCH RFC 1/8] golang/xenlight: > Create stub package"): >> I think the fastest thing to do to begin with would be to create a >> "null" logger that just throws away all the data

Re: [Xen-devel] [PATCH RFC 1/8] golang/xenlight: Create stub package

2017-01-26 Thread Ian Jackson
George Dunlap writes ("Re: [Xen-devel] [PATCH RFC 1/8] golang/xenlight: Create stub package"): > I think the fastest thing to do to begin with would be to create a > "null" logger that just throws away all the data. Then at some point > (possibly not in your intern

Re: [Xen-devel] [PATCH RFC 1/8] golang/xenlight: Create stub package

2017-01-26 Thread Ronald Rojas
On Wed, Jan 25, 2017 at 05:16:47PM +, George Dunlap wrote: > On Mon, Jan 23, 2017 at 4:43 PM, Ronald Rojas wrote: > > > +func (Ctx *Context) Open() (err error) { > > + if Ctx.ctx != nil { > > + return > > + } > > + > > + ret := C.libxl_ctx_alloc(unsafe.Pointer(

Re: [Xen-devel] [PATCH RFC 1/8] golang/xenlight: Create stub package

2017-01-26 Thread Ronald Rojas
On Wed, Jan 25, 2017 at 04:55:38PM +, Wei Liu wrote: > On Mon, Jan 23, 2017 at 11:43:30AM -0500, Ronald Rojas wrote: > [...] > > + > > +subdir-distclean-firmware: .phony > > + $(MAKE) -C firmware distclean > > + > > This looks unrelated. You're correct. Thanks for catching the mistake. > >

Re: [Xen-devel] [PATCH RFC 1/8] golang/xenlight: Create stub package

2017-01-25 Thread George Dunlap
On Mon, Jan 23, 2017 at 4:43 PM, Ronald Rojas wrote: > +func (Ctx *Context) Open() (err error) { > + if Ctx.ctx != nil { > + return > + } > + > + ret := C.libxl_ctx_alloc(unsafe.Pointer(&Ctx.ctx), C.LIBXL_VERSION, > 0, nil) Just discovered there's a bug here (in

Re: [Xen-devel] [PATCH RFC 1/8] golang/xenlight: Create stub package

2017-01-25 Thread Wei Liu
On Mon, Jan 23, 2017 at 11:43:30AM -0500, Ronald Rojas wrote: [...] > + > +subdir-distclean-firmware: .phony > + $(MAKE) -C firmware distclean > + This looks unrelated. > subdir-clean-debugger/gdbsx subdir-distclean-debugger/gdbsx: .phony > $(MAKE) -C debugger/gdbsx clean > > diff --

[Xen-devel] [PATCH RFC 1/8] golang/xenlight: Create stub package

2017-01-23 Thread Ronald Rojas
Create a basic Makefile to build and install libxenlight Golang bindings. Also add a stub package which only opens libxl context. Include a global xenlight.Ctx variable which can be used as the default context by the entire program if desired. For now, return simple errors. Proper error handling

Re: [Xen-devel] [PATCH RFC 1/8] golang/xenlight: Create stub package

2017-01-19 Thread George Dunlap
On 18/01/17 19:56, Ronald Rojas wrote: > Create a basic Makefile to build and install libxenlight Golang > bindings. Also add a stub package which only opens libxl context. > > Include a global xenlight.Ctx variable which can be used as the > default context by the entire program if desired. > >

Re: [Xen-devel] [PATCH RFC 1/8] golang/xenlight: Create stub package

2017-01-19 Thread George Dunlap
On 18/01/17 19:56, Ronald Rojas wrote: > Create a basic Makefile to build and install libxenlight Golang > bindings. Also add a stub package which only opens libxl context. > > Include a global xenlight.Ctx variable which can be used as the > default context by the entire program if desired. > >

Re: [Xen-devel] [PATCH RFC 1/8] golang/xenlight: Create stub package

2017-01-19 Thread George Dunlap
On 18/01/17 19:56, Ronald Rojas wrote: > Create a basic Makefile to build and install libxenlight Golang > bindings. Also add a stub package which only opens libxl context. > > Include a global xenlight.Ctx variable which can be used as the > default context by the entire program if desired. > >

Re: [Xen-devel] [PATCH RFC 1/8] golang/xenlight: Create stub package

2017-01-19 Thread Ronald Rojas
On Thu, Jan 19, 2017 at 12:03:22PM +, Wei Liu wrote: > On Wed, Jan 18, 2017 at 02:56:39PM -0500, Ronald Rojas wrote: > > > diff --git a/tools/golang/xenlight/Makefile b/tools/golang/xenlight/Makefile > > new file mode 100644 > > index 000..a45336b > > --- /dev/null > > +++ b/tools/golang

Re: [Xen-devel] [PATCH RFC 1/8] golang/xenlight: Create stub package

2017-01-19 Thread Wei Liu
On Wed, Jan 18, 2017 at 02:56:39PM -0500, Ronald Rojas wrote: > diff --git a/tools/golang/xenlight/Makefile b/tools/golang/xenlight/Makefile > new file mode 100644 > index 000..a45336b > --- /dev/null > +++ b/tools/golang/xenlight/Makefile > @@ -0,0 +1,29 @@ > +XEN_ROOT=$(CURDIR)/../../.. >

Re: [Xen-devel] [PATCH RFC 1/8] golang/xenlight: Create stub package

2017-01-18 Thread Ronald Rojas
On Wed, Jan 18, 2017 at 11:10:32PM +0100, Dario Faggioli wrote: > Hey, > > I'm afraid I can't comment on nothing, as I'm not at all into go. > > But there's a thing that I've noticed while skipping the patch out of > curiosity... > > On Wed, 2017-01-18 at 14:56 -0500, Ronald Rojas wrote: > > dif

Re: [Xen-devel] [PATCH RFC 1/8] golang/xenlight: Create stub package

2017-01-18 Thread Dario Faggioli
Hey, I'm afraid I can't comment on nothing, as I'm not at all into go. But there's a thing that I've noticed while skipping the patch out of curiosity... On Wed, 2017-01-18 at 14:56 -0500, Ronald Rojas wrote: > diff --git a/tools/Makefile b/tools/Makefile > index 77e0723..fd49e7f 100644 > --- a/

[Xen-devel] [PATCH RFC 1/8] golang/xenlight: Create stub package

2017-01-18 Thread Ronald Rojas
Create a basic Makefile to build and install libxenlight Golang bindings. Also add a stub package which only opens libxl context. Include a global xenlight.Ctx variable which can be used as the default context by the entire program if desired. For now, return simple errors. Proper error handling