Re: [Xen-devel] [PATCH RFC] libxl: fix paths in capability string

2015-01-07 Thread Jim Fehlig
Wei Liu wrote: > Jim, another idea: if those strings are likely to be wrong and in fact > not used, can we just not print them? > IMO they are useful, particularly when they are correct :-). They allow users to see which emulators are available and their complete path, which in turn can be dir

Re: [Xen-devel] [PATCH RFC] libxl: fix paths in capability string

2015-01-07 Thread Wei Liu
Jim, another idea: if those strings are likely to be wrong and in fact not used, can we just not print them? Wei. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH RFC] libxl: fix paths in capability string

2015-01-06 Thread Wei Liu
On Tue, Jan 06, 2015 at 05:03:59PM +, Ian Campbell wrote: > On Tue, 2015-01-06 at 16:12 +, Wei Liu wrote: > > No need to check hostarch to determine whether to use lib or lib64 > > anymore because we now always use lib. > > What about people who use --libdir=/path/to/lib64, as I believe Re

Re: [Xen-devel] [PATCH RFC] libxl: fix paths in capability string

2015-01-06 Thread Ian Campbell
On Tue, 2015-01-06 at 17:20 +, Wei Liu wrote: > On Tue, Jan 06, 2015 at 05:03:59PM +, Ian Campbell wrote: > > On Tue, 2015-01-06 at 16:12 +, Wei Liu wrote: > > > No need to check hostarch to determine whether to use lib or lib64 > > > anymore because we now always use lib. > > > > What

Re: [Xen-devel] [PATCH RFC] libxl: fix paths in capability string

2015-01-06 Thread Wei Liu
On Tue, Jan 06, 2015 at 04:50:53PM +, Frediano Ziglio wrote: > 2015-01-06 16:12 GMT+00:00 Wei Liu : > > Currently libxl driver hardcodes some paths in its capability string, > > which might not be the correct paths. > > > > This patch introduces --with-libxl-prefix, so that user can specify the

Re: [Xen-devel] [PATCH RFC] libxl: fix paths in capability string

2015-01-06 Thread Andrew Cooper
On 06/01/15 17:03, Ian Campbell wrote: > On Tue, 2015-01-06 at 16:12 +, Wei Liu wrote: >> No need to check hostarch to determine whether to use lib or lib64 >> anymore because we now always use lib. > What about people who use --libdir=/path/to/lib64, as I believe Red Hat > derived distros stil

Re: [Xen-devel] [PATCH RFC] libxl: fix paths in capability string

2015-01-06 Thread Ian Campbell
On Tue, 2015-01-06 at 16:12 +, Wei Liu wrote: > No need to check hostarch to determine whether to use lib or lib64 > anymore because we now always use lib. What about people who use --libdir=/path/to/lib64, as I believe Red Hat derived distros still do, don't they? Ian.

Re: [Xen-devel] [PATCH RFC] libxl: fix paths in capability string

2015-01-06 Thread Frediano Ziglio
2015-01-06 16:12 GMT+00:00 Wei Liu : > Currently libxl driver hardcodes some paths in its capability string, > which might not be the correct paths. > > This patch introduces --with-libxl-prefix, so that user can specify the > prefix used to build Xen tools. The default value is /usr/local which is

[Xen-devel] [PATCH RFC] libxl: fix paths in capability string

2015-01-06 Thread Wei Liu
Currently libxl driver hardcodes some paths in its capability string, which might not be the correct paths. This patch introduces --with-libxl-prefix, so that user can specify the prefix used to build Xen tools. The default value is /usr/local which is the default --prefix for Xen tools. Change e