Re: [Xen-devel] [PATCH RESEND 06/14] libxl/arm: Construct ACPI FADT table

2016-06-07 Thread Julien Grall
On 07/06/16 15:13, Shannon Zhao wrote: On 2016年06月07日 21:17, Julien Grall wrote: Hello Shannon, It just occurred to me that the way to build the ACPI tables, I am not speaking about the value, is very similar to what QEMU does. Yeah, TBH, I really refer to that in QEMU and there is no special

Re: [Xen-devel] [PATCH RESEND 06/14] libxl/arm: Construct ACPI FADT table

2016-06-07 Thread Shannon Zhao
On 2016年06月07日 21:17, Julien Grall wrote: > Hello Shannon, > > It just occurred to me that the way to build the ACPI tables, I am not > speaking about the value, is very similar to what QEMU does. > Yeah, TBH, I really refer to that in QEMU and there is no special difference between them to build

Re: [Xen-devel] [PATCH RESEND 06/14] libxl/arm: Construct ACPI FADT table

2016-06-07 Thread Julien Grall
Hello Shannon, It just occurred to me that the way to build the ACPI tables, I am not speaking about the value, is very similar to what QEMU does. Perhaps, we should copy the copyright from QEMU in libxl_arm.c. In this case, moving the ACPI code in a separate file would be the best. On 31/0

[Xen-devel] [PATCH RESEND 06/14] libxl/arm: Construct ACPI FADT table

2016-05-30 Thread Shannon Zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao --- tools/libxl/libxl_arm.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/tools/libxl/libxl_arm.c b/tools/libxl/libxl_arm.c index 0fb4f69..c3b8fb4 100644 --- a/tools/libxl/libxl_arm.c +++ b/tools/libxl/libxl_arm.c @@