Re: [Xen-devel] [PATCH QEMU-XEN] xen/pt: Start with emulated PCI_COMMAND set to zero.

2015-06-25 Thread Jan Beulich
>>> On 25.06.15 at 19:23, wrote: > On Thu, Jun 25, 2015 at 08:34:45AM +0100, Jan Beulich wrote: >> >>> On 24.06.15 at 17:59, wrote: >> > While digging in this I realized that some shortcuts and assumptions >> > had been taken (I think I am restating what you two have already >> > realized). >> >

Re: [Xen-devel] [PATCH QEMU-XEN] xen/pt: Start with emulated PCI_COMMAND set to zero.

2015-06-25 Thread Konrad Rzeszutek Wilk
On Thu, Jun 25, 2015 at 08:34:45AM +0100, Jan Beulich wrote: > >>> On 24.06.15 at 17:59, wrote: > > While digging in this I realized that some shortcuts and assumptions > > had been taken (I think I am restating what you two have already > > realized). > > > > 1) The dev.config is (by Xen code) u

Re: [Xen-devel] [PATCH QEMU-XEN] xen/pt: Start with emulated PCI_COMMAND set to zero.

2015-06-25 Thread Stefano Stabellini
On Thu, 25 Jun 2015, Jan Beulich wrote: > >>> On 24.06.15 at 17:59, wrote: > > While digging in this I realized that some shortcuts and assumptions > > had been taken (I think I am restating what you two have already > > realized). > > > > 1) The dev.config is (by Xen code) used as the cache of t

Re: [Xen-devel] [PATCH QEMU-XEN] xen/pt: Start with emulated PCI_COMMAND set to zero.

2015-06-25 Thread Jan Beulich
>>> On 24.06.15 at 17:59, wrote: > While digging in this I realized that some shortcuts and assumptions > had been taken (I think I am restating what you two have already > realized). > > 1) The dev.config is (by Xen code) used as the cache of the >host configuration devices (which is OK at i

Re: [Xen-devel] [PATCH QEMU-XEN] xen/pt: Start with emulated PCI_COMMAND set to zero.

2015-06-24 Thread Konrad Rzeszutek Wilk
On Tue, Jun 16, 2015 at 08:33:32AM +0100, Jan Beulich wrote: > >>> On 15.06.15 at 18:19, wrote: > > On Thu, 11 Jun 2015, Jan Beulich wrote: > >> >>> On 10.06.15 at 22:53, wrote: > >> > --- a/hw/xen/xen_pt.c > >> > +++ b/hw/xen/xen_pt.c > >> > @@ -785,7 +785,9 @@ out: > >> > xen_host_pci_

Re: [Xen-devel] [PATCH QEMU-XEN] xen/pt: Start with emulated PCI_COMMAND set to zero.

2015-06-16 Thread Jan Beulich
>>> On 15.06.15 at 18:19, wrote: > On Thu, 11 Jun 2015, Jan Beulich wrote: >> >>> On 10.06.15 at 22:53, wrote: >> > --- a/hw/xen/xen_pt.c >> > +++ b/hw/xen/xen_pt.c >> > @@ -785,7 +785,9 @@ out: >> > xen_host_pci_set_word(&s->real_device, PCI_COMMAND, >> >

Re: [Xen-devel] [PATCH QEMU-XEN] xen/pt: Start with emulated PCI_COMMAND set to zero.

2015-06-15 Thread Konrad Rzeszutek Wilk
On Mon, Jun 15, 2015 at 05:19:09PM +0100, Stefano Stabellini wrote: > On Thu, 11 Jun 2015, Jan Beulich wrote: > > >>> On 10.06.15 at 22:53, wrote: > > > --- a/hw/xen/xen_pt.c > > > +++ b/hw/xen/xen_pt.c > > > @@ -785,7 +785,9 @@ out: > > > xen_host_pci_set_word(&s->real_device, PCI_COMMAN

Re: [Xen-devel] [PATCH QEMU-XEN] xen/pt: Start with emulated PCI_COMMAND set to zero.

2015-06-15 Thread Stefano Stabellini
On Thu, 11 Jun 2015, Jan Beulich wrote: > >>> On 10.06.15 at 22:53, wrote: > > --- a/hw/xen/xen_pt.c > > +++ b/hw/xen/xen_pt.c > > @@ -785,7 +785,9 @@ out: > > xen_host_pci_set_word(&s->real_device, PCI_COMMAND, > >pci_get_word(d->config + PCI_COMMAND) | cm

Re: [Xen-devel] [PATCH QEMU-XEN] xen/pt: Start with emulated PCI_COMMAND set to zero.

2015-06-12 Thread Konrad Rzeszutek Wilk
On Thu, Jun 11, 2015 at 01:19:34PM +0200, Sander Eikelenboom wrote: > > Thursday, June 11, 2015, 9:47:47 AM, you wrote: > > On 10.06.15 at 22:53, wrote: > >> --- a/hw/xen/xen_pt.c > >> +++ b/hw/xen/xen_pt.c > >> @@ -785,7 +785,9 @@ out: > >> xen_host_pci_set_word(&s->real_device, P

Re: [Xen-devel] [PATCH QEMU-XEN] xen/pt: Start with emulated PCI_COMMAND set to zero.

2015-06-11 Thread Sander Eikelenboom
Thursday, June 11, 2015, 9:47:47 AM, you wrote: On 10.06.15 at 22:53, wrote: >> --- a/hw/xen/xen_pt.c >> +++ b/hw/xen/xen_pt.c >> @@ -785,7 +785,9 @@ out: >> xen_host_pci_set_word(&s->real_device, PCI_COMMAND, >>pci_get_word(d->config + PCI_COMMAND)

Re: [Xen-devel] [PATCH QEMU-XEN] xen/pt: Start with emulated PCI_COMMAND set to zero.

2015-06-11 Thread Jan Beulich
>>> On 10.06.15 at 22:53, wrote: > --- a/hw/xen/xen_pt.c > +++ b/hw/xen/xen_pt.c > @@ -785,7 +785,9 @@ out: > xen_host_pci_set_word(&s->real_device, PCI_COMMAND, >pci_get_word(d->config + PCI_COMMAND) | cmd); > } > - > +/* Until the guest enables t

[Xen-devel] [PATCH QEMU-XEN] xen/pt: Start with emulated PCI_COMMAND set to zero.

2015-06-10 Thread konrad
From: Konrad Rzeszutek Wilk For a passthrough device we maintain a state of emulated registers value contained within d->config. We also consult the host registers (and apply ro and write masks) whenever the guest access the registers. This is done in xen_pt_pci_write_config and xen_pt_pci_read_c