Re: [Xen-devel] [PATCH OSSTEST v3 01/13] toolstack: save / restore check

2015-07-24 Thread Ian Campbell
On Thu, 2015-07-23 at 17:45 +0100, Wei Liu wrote: > On Thu, Jul 23, 2015 at 05:16:45PM +0100, Ian Campbell wrote: > > On Wed, 2015-07-22 at 11:13 +0100, Wei Liu wrote: > > > +++ b/Osstest/Toolstack/libvirt.pm > > > [...] > > > +sub saverestore_check ($) { > > > +my ($self) = @_; > > > +retu

Re: [Xen-devel] [PATCH OSSTEST v3 01/13] toolstack: save / restore check

2015-07-23 Thread Wei Liu
On Thu, Jul 23, 2015 at 05:16:45PM +0100, Ian Campbell wrote: > On Wed, 2015-07-22 at 11:13 +0100, Wei Liu wrote: > > +++ b/Osstest/Toolstack/libvirt.pm > > [...] > > +sub saverestore_check ($) { > > +my ($self) = @_; > > +return check_for_command($self, "save"); > > I just noticed that in

Re: [Xen-devel] [PATCH OSSTEST v3 01/13] toolstack: save / restore check

2015-07-23 Thread Ian Campbell
On Wed, 2015-07-22 at 11:13 +0100, Wei Liu wrote: > +++ b/Osstest/Toolstack/libvirt.pm > [...] > +sub saverestore_check ($) { > +my ($self) = @_; > +return check_for_command($self, "save"); I just noticed that in a later patch you parse the capabilities xml to check for migration support.

Re: [Xen-devel] [PATCH OSSTEST v3 01/13] toolstack: save / restore check

2015-07-23 Thread Ian Campbell
On Wed, 2015-07-22 at 11:13 +0100, Wei Liu wrote: > Introduce check_for_command function and use it to check save / > restore > functionality. > > Signed-off-by: Wei Liu Acked-by: Ian Campbell ___ Xen-devel mailing list Xen-devel@lists.xen.org http

[Xen-devel] [PATCH OSSTEST v3 01/13] toolstack: save / restore check

2015-07-22 Thread Wei Liu
Introduce check_for_command function and use it to check save / restore functionality. Signed-off-by: Wei Liu --- v3: remove $TOOLSTACK prefix. v2: introduce $TOOLSTACK_check_for_command function. --- Osstest/Toolstack/libvirt.pm | 14 ++ Osstest/Toolstack/xend.pm| 3 +++ Osstes