Re: [Xen-devel] [PATCH OSSTEST 04/11] TestSupport: introduce set_host_prop

2017-08-01 Thread Roger Pau Monne
On Tue, Aug 01, 2017 at 04:07:18PM +0100, Ian Jackson wrote: > Roger Pau Monne writes ("Re: [PATCH OSSTEST 04/11] TestSupport: introduce > set_host_prop"): > > After reading README osstest doesn't seem to have any limitation on > > the characters that can be used for host idents, would you be fine

Re: [Xen-devel] [PATCH OSSTEST 04/11] TestSupport: introduce set_host_prop

2017-08-01 Thread Ian Jackson
Roger Pau Monne writes ("Re: [PATCH OSSTEST 04/11] TestSupport: introduce set_host_prop"): > After reading README osstest doesn't seem to have any limitation on > the characters that can be used for host idents, would you be fine > with me modifying it to add that '-' cannot be used in host idents

Re: [Xen-devel] [PATCH OSSTEST 04/11] TestSupport: introduce set_host_prop

2017-08-01 Thread Roger Pau Monne
On Tue, Aug 01, 2017 at 03:13:33PM +0100, Ian Jackson wrote: > Roger Pau Monne writes ("Re: [PATCH OSSTEST 04/11] TestSupport: introduce > set_host_prop"): > > On Tue, Aug 01, 2017 at 02:01:35PM +0100, Ian Jackson wrote: > > > TBH, since this is only being called in the one > > > ts-set-host-prope

Re: [Xen-devel] [PATCH OSSTEST 04/11] TestSupport: introduce set_host_prop

2017-08-01 Thread Ian Jackson
Roger Pau Monne writes ("Re: [PATCH OSSTEST 04/11] TestSupport: introduce set_host_prop"): > On Tue, Aug 01, 2017 at 02:01:35PM +0100, Ian Jackson wrote: > > TBH, since this is only being called in the one > > ts-set-host-properties-from-runvars script (or whatever you're calling > > it), I think

Re: [Xen-devel] [PATCH OSSTEST 04/11] TestSupport: introduce set_host_prop

2017-08-01 Thread Roger Pau Monne
On Tue, Aug 01, 2017 at 02:01:35PM +0100, Ian Jackson wrote: > Roger Pau Monne writes ("Re: [PATCH OSSTEST 04/11] TestSupport: introduce > set_host_prop"): > > IMHO, I think the right approach is to leave mg-hosts as it is now, > > Yes. > > > and implement a set_property in HostDB/{Executive/Sta

Re: [Xen-devel] [PATCH OSSTEST 04/11] TestSupport: introduce set_host_prop

2017-08-01 Thread Ian Jackson
Roger Pau Monne writes ("Re: [PATCH OSSTEST 04/11] TestSupport: introduce set_host_prop"): > IMHO, I think the right approach is to leave mg-hosts as it is now, Yes. > and implement a set_property in HostDB/{Executive/Static}.pm and > implement a helper in TestSupport that makes use of it > ($mh

Re: [Xen-devel] [PATCH OSSTEST 04/11] TestSupport: introduce set_host_prop

2017-08-01 Thread Roger Pau Monne
On Fri, Jul 28, 2017 at 04:39:04PM +0100, Ian Jackson wrote: > Roger Pau Monne writes ("[PATCH OSSTEST 04/11] TestSupport: introduce > set_host_prop"): > > This is from the code in mg-hosts. Switch cmd_setprops to use the > > newly introduced function. > > I think this needs to be abstracted thro

Re: [Xen-devel] [PATCH OSSTEST 04/11] TestSupport: introduce set_host_prop

2017-07-28 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH OSSTEST 04/11] TestSupport: introduce set_host_prop"): > This is from the code in mg-hosts. Switch cmd_setprops to use the > newly introduced function. I think this needs to be abstracted through jobdb. Certainly these SQL statements operating on the host_properti

[Xen-devel] [PATCH OSSTEST 04/11] TestSupport: introduce set_host_prop

2017-07-28 Thread Roger Pau Monne
This is from the code in mg-hosts. Switch cmd_setprops to use the newly introduced function. No functional change. Signed-off-by: Roger Pau Monné --- Osstest/TestSupport.pm | 31 ++- mg-hosts | 31 +-- 2 files changed, 31 ins