Re: [Xen-devel] [PATCH OSSTEST] standalone: Log things we are running via with_logging

2015-12-04 Thread Ian Jackson
Ian Campbell writes ("Re: [PATCH OSSTEST] standalone: Log things we are running via with_logging"): > On Thu, 2015-12-03 at 16:41 +, Ian Jackson wrote: > > It's not clear to me from the context whether $@ might contain things > > which would require quoting. ... > Are you worried about things

Re: [Xen-devel] [PATCH OSSTEST] standalone: Log things we are running via with_logging

2015-12-04 Thread Ian Campbell
On Thu, 2015-12-03 at 16:41 +, Ian Jackson wrote: > Ian Campbell writes ("[PATCH OSSTEST] standalone: Log things we are > running via with_logging"): > > Turning on set -x is too verbose, so just echo the command ourselves. > > It's not clear to me from the context whether $@ might contain thi

Re: [Xen-devel] [PATCH OSSTEST] standalone: Log things we are running via with_logging

2015-12-03 Thread Ian Jackson
Ian Campbell writes ("[PATCH OSSTEST] standalone: Log things we are running via with_logging"): > Turning on set -x is too verbose, so just echo the command ourselves. It's not clear to me from the context whether $@ might contain things which would require quoting. set -x would quote them. You

[Xen-devel] [PATCH OSSTEST] standalone: Log things we are running via with_logging

2015-12-03 Thread Ian Campbell
Turning on set -x is too verbose, so just echo the command ourselves. Signed-off-by: Ian Campbell --- standalone | 1 + 1 file changed, 1 insertion(+) diff --git a/standalone b/standalone index c804b74..6897400 100755 --- a/standalone +++ b/standalone @@ -195,6 +195,7 @@ with_logging() { i