Re: [Xen-devel] [PATCH 7/7] xen: sched_rt: print useful affinity info when dumping

2015-03-17 Thread Meng Xu
Hi Dario, 2015-03-17 10:12 GMT-04:00 Dario Faggioli : > On Mon, 2015-03-16 at 16:30 -0400, Meng Xu wrote: >> Hi Dario, >> > Hey, > >> 2015-03-16 13:05 GMT-04:00 Dario Faggioli : > >> > >> > This change also takes the chance to add a scratch >> > cpumask, to avoid having to create one more >> > cpu

Re: [Xen-devel] [PATCH 7/7] xen: sched_rt: print useful affinity info when dumping

2015-03-17 Thread Meng Xu
>>> >>> This change also takes the chance to add a scratch >>> cpumask, to avoid having to create one more >>> cpumask_var_t on the stack of the dumping routine. >> >> Actually, I have a question about the strength of this design. When we >> have a machine with many cpus, we will end up with alloca

Re: [Xen-devel] [PATCH 7/7] xen: sched_rt: print useful affinity info when dumping

2015-03-17 Thread Dario Faggioli
On Mon, 2015-03-16 at 16:30 -0400, Meng Xu wrote: > Hi Dario, > Hey, > 2015-03-16 13:05 GMT-04:00 Dario Faggioli : > > > > This change also takes the chance to add a scratch > > cpumask, to avoid having to create one more > > cpumask_var_t on the stack of the dumping routine. > > Actually, I ha

Re: [Xen-devel] [PATCH 7/7] xen: sched_rt: print useful affinity info when dumping

2015-03-17 Thread Dario Faggioli
On Mon, 2015-03-16 at 19:05 +, George Dunlap wrote: > On 03/16/2015 05:05 PM, Dario Faggioli wrote: > > @@ -218,7 +224,6 @@ __q_elem(struct list_head *elem) > > static void > > rt_dump_vcpu(const struct scheduler *ops, const struct rt_vcpu *svc) > > { > > -char cpustr[1024]; > > cp

Re: [Xen-devel] [PATCH 7/7] xen: sched_rt: print useful affinity info when dumping

2015-03-17 Thread Jan Beulich
>>> On 17.03.15 at 12:10, wrote: > On 03/16/2015 08:30 PM, Meng Xu wrote: >> 2015-03-16 13:05 GMT-04:00 Dario Faggioli : >>> This change also takes the chance to add a scratch >>> cpumask, to avoid having to create one more >>> cpumask_var_t on the stack of the dumping routine. >> >> Actually, I

Re: [Xen-devel] [PATCH 7/7] xen: sched_rt: print useful affinity info when dumping

2015-03-17 Thread George Dunlap
On 03/16/2015 08:30 PM, Meng Xu wrote: > Hi Dario, > > 2015-03-16 13:05 GMT-04:00 Dario Faggioli : >> In fact, printing the cpupool's CPU online mask >> for each vCPU is just redundant, as that is the >> same for all the vCPUs of all the domains in the >> same cpupool, while hard affinity is alrea

Re: [Xen-devel] [PATCH 7/7] xen: sched_rt: print useful affinity info when dumping

2015-03-16 Thread Meng Xu
Hi Dario, 2015-03-16 13:05 GMT-04:00 Dario Faggioli : > In fact, printing the cpupool's CPU online mask > for each vCPU is just redundant, as that is the > same for all the vCPUs of all the domains in the > same cpupool, while hard affinity is already part > of the output of dumping domains info.

Re: [Xen-devel] [PATCH 7/7] xen: sched_rt: print useful affinity info when dumping

2015-03-16 Thread George Dunlap
On 03/16/2015 05:05 PM, Dario Faggioli wrote: > In fact, printing the cpupool's CPU online mask > for each vCPU is just redundant, as that is the > same for all the vCPUs of all the domains in the > same cpupool, while hard affinity is already part > of the output of dumping domains info. > > Inst

[Xen-devel] [PATCH 7/7] xen: sched_rt: print useful affinity info when dumping

2015-03-16 Thread Dario Faggioli
In fact, printing the cpupool's CPU online mask for each vCPU is just redundant, as that is the same for all the vCPUs of all the domains in the same cpupool, while hard affinity is already part of the output of dumping domains info. Instead, print the intersection between hard affinity and online