Re: [Xen-devel] [PATCH 6/6] x86emul: simplify FPU handling asm() constraints

2016-12-07 Thread Jan Beulich
>>> On 07.12.16 at 16:16, wrote: > On 06/12/16 14:14, Jan Beulich wrote: >> The memory clobber is rather harsh here. > > Does removing it actually make a difference? I can't spot anything > which could reasonably be reordered around the asm() blocks. It's not so much the re-ordering but the pot

Re: [Xen-devel] [PATCH 6/6] x86emul: simplify FPU handling asm() constraints

2016-12-07 Thread Andrew Cooper
On 06/12/16 14:14, Jan Beulich wrote: > The memory clobber is rather harsh here. Does removing it actually make a difference? I can't spot anything which could reasonably be reordered around the asm() blocks. > However, fic.exn_raised may be > modified as a side effect, so we need to let the com

[Xen-devel] [PATCH 6/6] x86emul: simplify FPU handling asm() constraints

2016-12-06 Thread Jan Beulich
The memory clobber is rather harsh here. However, fic.exn_raised may be modified as a side effect, so we need to let the compiler know that all of "fic" may be changed (preventing it from moving around accesses to the exn_raised field). Signed-off-by: Jan Beulich --- a/xen/arch/x86/x86_emulate/x