Re: [Xen-devel] [PATCH 5/9] libxl: avoid leaking string in cpupool_info

2015-07-13 Thread Wei Liu
On Mon, Jul 13, 2015 at 05:23:10PM +0100, Ian Campbell wrote: > On Mon, 2015-07-13 at 17:10 +0100, Wei Liu wrote: > > On Mon, Jul 13, 2015 at 11:07:31AM +0100, Ian Campbell wrote: > > > On Fri, 2015-07-10 at 19:00 +0100, Wei Liu wrote: > > > > Signed-off-by: Wei Liu > > > > > > Would an "if (rc)

Re: [Xen-devel] [PATCH 5/9] libxl: avoid leaking string in cpupool_info

2015-07-13 Thread Ian Campbell
On Mon, 2015-07-13 at 17:10 +0100, Wei Liu wrote: > On Mon, Jul 13, 2015 at 11:07:31AM +0100, Ian Campbell wrote: > > On Fri, 2015-07-10 at 19:00 +0100, Wei Liu wrote: > > > Signed-off-by: Wei Liu > > > > Would an "if (rc) libxl_cpupoolinfo_dispose(info)" on the exit path be a > > more robust alt

Re: [Xen-devel] [PATCH 5/9] libxl: avoid leaking string in cpupool_info

2015-07-13 Thread Wei Liu
On Mon, Jul 13, 2015 at 11:07:31AM +0100, Ian Campbell wrote: > On Fri, 2015-07-10 at 19:00 +0100, Wei Liu wrote: > > Signed-off-by: Wei Liu > > Would an "if (rc) libxl_cpupoolinfo_dispose(info)" on the exit path be a > more robust alternative? Might require the addition of a > libxl_cpupoolinfo_

Re: [Xen-devel] [PATCH 5/9] libxl: avoid leaking string in cpupool_info

2015-07-13 Thread Ian Campbell
On Fri, 2015-07-10 at 19:00 +0100, Wei Liu wrote: > Signed-off-by: Wei Liu Would an "if (rc) libxl_cpupoolinfo_dispose(info)" on the exit path be a more robust alternative? Might require the addition of a libxl_cpupoolinfo_init() somewhere before any possible error. > --- > tools/libxl/libxl.c

[Xen-devel] [PATCH 5/9] libxl: avoid leaking string in cpupool_info

2015-07-10 Thread Wei Liu
Signed-off-by: Wei Liu --- tools/libxl/libxl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index 38aff8d..4151dcb 100644 --- a/tools/libxl/libxl.c +++ b/tools/libxl/libxl.c @@ -740,8 +740,10 @@ static int cpupool_info(libxl__gc