Re: [Xen-devel] [PATCH 5/7] xenalyze: disable sched_switch_process

2015-05-03 Thread Olaf Hering
On Sat, May 02, Wei Liu wrote: > Ergh... George might have an idea of the bug you met. > > I'm not in favour of short-circuiting code like this. If this is really > necessary please either delete dead code or use #ifdef 0 with proper > comment. I will drop that change for now. Olaf ___

Re: [Xen-devel] [PATCH 5/7] xenalyze: disable sched_switch_process

2015-05-02 Thread Wei Liu
On Tue, Apr 28, 2015 at 07:58:44AM +0200, Olaf Hering wrote: > On Tue, Apr 28, Wei Liu wrote: > > > On Mon, Apr 27, 2015 at 01:22:14PM +, Olaf Hering wrote: > > > It causes a crash, dump data and return early > > > This doesn't look right. You skip all things below. > > Yes, to avoid the cra

Re: [Xen-devel] [PATCH 5/7] xenalyze: disable sched_switch_process

2015-04-27 Thread Olaf Hering
On Tue, Apr 28, Wei Liu wrote: > On Mon, Apr 27, 2015 at 01:22:14PM +, Olaf Hering wrote: > > It causes a crash, dump data and return early > This doesn't look right. You skip all things below. Yes, to avoid the crash when booted with "tbuf_size=-1". When I noticed that I did not have the en

Re: [Xen-devel] [PATCH 5/7] xenalyze: disable sched_switch_process

2015-04-27 Thread Wei Liu
On Mon, Apr 27, 2015 at 01:22:14PM +, Olaf Hering wrote: > It causes a crash, dump data and return early > > Signed-off-by: Olaf Hering > Cc: Ian Jackson > Cc: Stefano Stabellini > Cc: Ian Campbell > Cc: Wei Liu > --- > tools/misc/xenalyze.c | 4 > 1 file changed, 4 insertions(+) >

[Xen-devel] [PATCH 5/7] xenalyze: disable sched_switch_process

2015-04-27 Thread Olaf Hering
It causes a crash, dump data and return early Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu --- tools/misc/xenalyze.c | 4 1 file changed, 4 insertions(+) diff --git a/tools/misc/xenalyze.c b/tools/misc/xenalyze.c index 0566d00..67b44b5