Re: [Xen-devel] [PATCH 5/7] libxc: Removing dead code from xc_dom_allocate()

2015-07-03 Thread Ian Jackson
Ian Campbell writes ("Re: [Xen-devel] [PATCH 5/7] libxc: Removing dead code from xc_dom_allocate()"): > I'd be ok with either leaving this as is (and tagging CID 1055188 as > intentioanl) or adding the null initialiser as you suggested in your > "However: " I w

Re: [Xen-devel] [PATCH 5/7] libxc: Removing dead code from xc_dom_allocate()

2015-07-03 Thread Ian Campbell
On Fri, 2015-07-03 at 16:33 +0100, Ian Jackson wrote: > Ian Campbell writes ("Re: [Xen-devel] [PATCH 5/7] libxc: Removing dead code > from xc_dom_allocate()"): > > On Fri, 2015-07-03 at 16:24 +0100, Ian Jackson wrote: > > > Jennifer Herbert writes ("[Xen-dev

Re: [Xen-devel] [PATCH 5/7] libxc: Removing dead code from xc_dom_allocate()

2015-07-03 Thread Ian Jackson
Ian Campbell writes ("Re: [Xen-devel] [PATCH 5/7] libxc: Removing dead code from xc_dom_allocate()"): > On Fri, 2015-07-03 at 16:24 +0100, Ian Jackson wrote: > > Jennifer Herbert writes ("[Xen-devel] [PATCH 5/7] libxc: Removing dead code > > from xc_dom_allocate(

Re: [Xen-devel] [PATCH 5/7] libxc: Removing dead code from xc_dom_allocate()

2015-07-03 Thread Ian Campbell
On Fri, 2015-07-03 at 16:24 +0100, Ian Jackson wrote: > Jennifer Herbert writes ("[Xen-devel] [PATCH 5/7] libxc: Removing dead code > from xc_dom_allocate()"): > > The only place that jumps to 'err:' does so because !dom, which is > > rechecked in 'err

Re: [Xen-devel] [PATCH 5/7] libxc: Removing dead code from xc_dom_allocate()

2015-07-03 Thread Ian Jackson
Jennifer Herbert writes ("[Xen-devel] [PATCH 5/7] libxc: Removing dead code from xc_dom_allocate()"): > The only place that jumps to 'err:' does so because !dom, which is > rechecked in 'err:'. This patch simplifies, giving the same result. I'm not p

Re: [Xen-devel] [PATCH 5/7] libxc: Removing dead code from xc_dom_allocate()

2015-07-03 Thread Andrew Cooper
On 01/07/15 18:37, Jennifer Herbert wrote: > The only place that jumps to 'err:' does so because !dom, which is > rechecked in 'err:'. This patch simplifies, giving the same result. > > Signed-off-by: Jennifer Herbert Coverity-ID: 1055188 ~Andrew > --- > tools/libxc/xc_dom_core.c |7 +

[Xen-devel] [PATCH 5/7] libxc: Removing dead code from xc_dom_allocate()

2015-07-01 Thread Jennifer Herbert
The only place that jumps to 'err:' does so because !dom, which is rechecked in 'err:'. This patch simplifies, giving the same result. Signed-off-by: Jennifer Herbert --- tools/libxc/xc_dom_core.c |7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/tools/libxc/xc_dom_co