Re: [Xen-devel] [PATCH 5/5] xen: clean up VPF flags macros

2015-09-28 Thread Juergen Gross
On 09/28/2015 10:34 AM, Jan Beulich wrote: On 28.09.15 at 10:15, wrote: On 09/28/2015 09:52 AM, Jan Beulich wrote: On 28.09.15 at 09:29, wrote: On 09/28/2015 08:22 AM, Jan Beulich wrote: On 28.09.15 at 07:23, wrote: On 09/25/2015 05:42 PM, Jan Beulich wrote: On 25.09.15 at 13:54, wrote:

Re: [Xen-devel] [PATCH 5/5] xen: clean up VPF flags macros

2015-09-28 Thread Jan Beulich
>>> On 28.09.15 at 10:15, wrote: > On 09/28/2015 09:52 AM, Jan Beulich wrote: > On 28.09.15 at 09:29, wrote: >>> On 09/28/2015 08:22 AM, Jan Beulich wrote: >>> On 28.09.15 at 07:23, wrote: > On 09/25/2015 05:42 PM, Jan Beulich wrote: > On 25.09.15 at 13:54, wrote: >>> --

Re: [Xen-devel] [PATCH 5/5] xen: clean up VPF flags macros

2015-09-28 Thread Juergen Gross
On 09/28/2015 09:52 AM, Jan Beulich wrote: On 28.09.15 at 09:29, wrote: On 09/28/2015 08:22 AM, Jan Beulich wrote: On 28.09.15 at 07:23, wrote: On 09/25/2015 05:42 PM, Jan Beulich wrote: On 25.09.15 at 13:54, wrote: Per-VCPU pause flags in sched.h are defined as bit positions and as value

Re: [Xen-devel] [PATCH 5/5] xen: clean up VPF flags macros

2015-09-28 Thread Jan Beulich
>>> On 28.09.15 at 09:29, wrote: > On 09/28/2015 08:22 AM, Jan Beulich wrote: > On 28.09.15 at 07:23, wrote: >>> On 09/25/2015 05:42 PM, Jan Beulich wrote: >>> On 25.09.15 at 13:54, wrote: > Per-VCPU pause flags in sched.h are defined as bit positions and as > values derived from

Re: [Xen-devel] [PATCH 5/5] xen: clean up VPF flags macros

2015-09-28 Thread Juergen Gross
On 09/28/2015 08:22 AM, Jan Beulich wrote: On 28.09.15 at 07:23, wrote: On 09/25/2015 05:42 PM, Jan Beulich wrote: On 25.09.15 at 13:54, wrote: Per-VCPU pause flags in sched.h are defined as bit positions and as values derived from the bit defines. There is only one user of a value which can

Re: [Xen-devel] [PATCH 5/5] xen: clean up VPF flags macros

2015-09-27 Thread Jan Beulich
>>> On 28.09.15 at 07:23, wrote: > On 09/25/2015 05:42 PM, Jan Beulich wrote: > On 25.09.15 at 13:54, wrote: >>> Per-VCPU pause flags in sched.h are defined as bit positions and as >>> values derived from the bit defines. There is only one user of a value >>> which can be easily converted to

Re: [Xen-devel] [PATCH 5/5] xen: clean up VPF flags macros

2015-09-27 Thread Juergen Gross
On 09/25/2015 05:42 PM, Jan Beulich wrote: On 25.09.15 at 13:54, wrote: Per-VCPU pause flags in sched.h are defined as bit positions and as values derived from the bit defines. There is only one user of a value which can be easily converted to use a bit number as well. I'm not convinced: --

Re: [Xen-devel] [PATCH 5/5] xen: clean up VPF flags macros

2015-09-25 Thread Jan Beulich
>>> On 25.09.15 at 13:54, wrote: > Per-VCPU pause flags in sched.h are defined as bit positions and as > values derived from the bit defines. There is only one user of a value > which can be easily converted to use a bit number as well. I'm not convinced: > --- a/xen/common/domctl.c > +++ b/xen/

[Xen-devel] [PATCH 5/5] xen: clean up VPF flags macros

2015-09-25 Thread Juergen Gross
Per-VCPU pause flags in sched.h are defined as bit positions and as values derived from the bit defines. There is only one user of a value which can be easily converted to use a bit number as well. Remove the value definitions and do the conversion for the only user. Signed-off-by: Juergen Gross