Re: [Xen-devel] [PATCH 4/5] x86/pv: Simplify access to the LDT/GDT ptes

2017-08-29 Thread Jan Beulich
>>> On 29.08.17 at 13:19, wrote: > Rename gdt_ldt_ptes() to pv_gdt_ptes() and drop the domain parameter, as it is > incorrect to use the helper with d != v->domain. Indeed, but it was still done this way for a reason: > --- a/xen/include/asm-x86/domain.h > +++ b/xen/include/asm-x86/domain.h > @@

Re: [Xen-devel] [PATCH 4/5] x86/pv: Simplify access to the LDT/GDT ptes

2017-08-29 Thread Wei Liu
On Tue, Aug 29, 2017 at 12:19:15PM +0100, Andrew Cooper wrote: > Rename gdt_ldt_ptes() to pv_gdt_ptes() and drop the domain parameter, as it is > incorrect to use the helper with d != v->domain. > > Introduce pv_ldt_ptes() to abstract away the fact that the LDT mapping is 16 > slots after the GDT,

[Xen-devel] [PATCH 4/5] x86/pv: Simplify access to the LDT/GDT ptes

2017-08-29 Thread Andrew Cooper
Rename gdt_ldt_ptes() to pv_gdt_ptes() and drop the domain parameter, as it is incorrect to use the helper with d != v->domain. Introduce pv_ldt_ptes() to abstract away the fact that the LDT mapping is 16 slots after the GDT, and adjust the callers accordingly. Signed-off-by: Andrew Cooper --- C