Re: [Xen-devel] [PATCH 4/4] xen/ubsan: Introduce and use CONFIG_UBSAN

2017-10-05 Thread Wei Liu
On Thu, Oct 05, 2017 at 08:49:36AM -0400, Konrad Rzeszutek Wilk wrote: > > +config UBSAN > > + bool "Undefined behaviour sanitizer" > > + depends on X86 > > + ---help--- > > + Enable undefined behaviour sanitizer. > > + > > + If unsure, say N here. > > Could you perhaps expand it a b

Re: [Xen-devel] [PATCH 4/4] xen/ubsan: Introduce and use CONFIG_UBSAN

2017-10-05 Thread Konrad Rzeszutek Wilk
> +config UBSAN > + bool "Undefined behaviour sanitizer" > + depends on X86 > + ---help--- > + Enable undefined behaviour sanitizer. > + > + If unsure, say N here. Could you perhaps expand it a bit? How does it sanitize it? With soap :-)? And what 'undefinded behaviour's ar

Re: [Xen-devel] [PATCH 4/4] xen/ubsan: Introduce and use CONFIG_UBSAN

2017-10-04 Thread Jan Beulich
>>> On 04.10.17 at 15:28, wrote: > On 04/10/17 13:03, Jan Beulich wrote: > On 03.10.17 at 20:07, wrote: >>> --- a/xen/Kconfig >>> +++ b/xen/Kconfig >>> @@ -38,4 +38,10 @@ config LTO >>> >>> If unsure, say N. >>> >>> +# >>> +# For architectures that know their GCC __int128 support is

Re: [Xen-devel] [PATCH 4/4] xen/ubsan: Introduce and use CONFIG_UBSAN

2017-10-04 Thread Andrew Cooper
On 04/10/17 13:03, Jan Beulich wrote: On 03.10.17 at 20:07, wrote: >> --- a/xen/Kconfig >> +++ b/xen/Kconfig >> @@ -38,4 +38,10 @@ config LTO >> >>If unsure, say N. >> >> +# >> +# For architectures that know their GCC __int128 support is sound >> +# >> +config ARCH_SUPPORTS_INT128

Re: [Xen-devel] [PATCH 4/4] xen/ubsan: Introduce and use CONFIG_UBSAN

2017-10-04 Thread Jan Beulich
>>> On 03.10.17 at 20:07, wrote: > --- a/xen/Kconfig > +++ b/xen/Kconfig > @@ -38,4 +38,10 @@ config LTO > > If unsure, say N. > > +# > +# For architectures that know their GCC __int128 support is sound > +# > +config ARCH_SUPPORTS_INT128 > + bool Why GCC? What about Clang? > ---

Re: [Xen-devel] [PATCH 4/4] xen/ubsan: Introduce and use CONFIG_UBSAN

2017-10-04 Thread Andrew Cooper
On 03/10/17 19:07, Andrew Cooper wrote: > TODO at some future point: Fix the following known issues: > > Clang 3.9 - linker error in shadow/multi.c with fetch_type_names[]. With > UBSAN enabled, it appears that dead code elimination doesn't remove the > single reference to fetch_type_names[]

Re: [Xen-devel] [PATCH 4/4] xen/ubsan: Introduce and use CONFIG_UBSAN

2017-10-04 Thread Wei Liu
On Tue, Oct 03, 2017 at 07:07:53PM +0100, Andrew Cooper wrote: > Tested with GCC 4.9 of Debian Jessie. > > Signed-off-by: Andrew Cooper > Signed-off-by: Wei Liu Series: Reviewed-by: Wei Liu Tested-by: Wei Liu with GCC 6.3 ___ Xen-devel mailing lis

[Xen-devel] [PATCH 4/4] xen/ubsan: Introduce and use CONFIG_UBSAN

2017-10-03 Thread Andrew Cooper
Tested with GCC 4.9 of Debian Jessie. Signed-off-by: Andrew Cooper Signed-off-by: Wei Liu --- CC: George Dunlap CC: Jan Beulich CC: Konrad Rzeszutek Wilk CC: Stefano Stabellini CC: Tim Deegan CC: Wei Liu CC: Julien Grall TODO at some future point: Fix the following known issues: Clang