Re: [Xen-devel] [PATCH 4/4] x86/vmx: Drop vmx_msr_state infrastructure

2017-02-13 Thread Tian, Kevin
> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Monday, February 13, 2017 10:33 PM > > To avoid leaking host MSR state into guests, guest LSTAR, STAR and > SYSCALL_MASK state is unconditionally loaded when switching into guest > context. > > Attempting to dirty-track the state is

Re: [Xen-devel] [PATCH 4/4] x86/vmx: Drop vmx_msr_state infrastructure

2017-02-13 Thread Jan Beulich
>>> On 13.02.17 at 17:22, wrote: > On 13/02/17 16:12, Andrew Cooper wrote: >> On 13/02/17 16:01, Jan Beulich wrote: >> On 13.02.17 at 15:32, wrote: To avoid leaking host MSR state into guests, guest LSTAR, STAR and SYSCALL_MASK state is unconditionally loaded when switching into gue

Re: [Xen-devel] [PATCH 4/4] x86/vmx: Drop vmx_msr_state infrastructure

2017-02-13 Thread Jan Beulich
>>> On 13.02.17 at 17:12, wrote: > On 13/02/17 16:01, Jan Beulich wrote: > On 13.02.17 at 15:32, wrote: >>> To avoid leaking host MSR state into guests, guest LSTAR, STAR and >>> SYSCALL_MASK state is unconditionally loaded when switching into guest >>> context. >>> >>> Attempting to dirty-tr

Re: [Xen-devel] [PATCH 4/4] x86/vmx: Drop vmx_msr_state infrastructure

2017-02-13 Thread Andrew Cooper
On 13/02/17 16:12, Andrew Cooper wrote: > On 13/02/17 16:01, Jan Beulich wrote: > On 13.02.17 at 15:32, wrote: >>> To avoid leaking host MSR state into guests, guest LSTAR, STAR and >>> SYSCALL_MASK state is unconditionally loaded when switching into guest >>> context. >>> >>> Attempting to di

Re: [Xen-devel] [PATCH 4/4] x86/vmx: Drop vmx_msr_state infrastructure

2017-02-13 Thread Andrew Cooper
On 13/02/17 16:01, Jan Beulich wrote: On 13.02.17 at 15:32, wrote: >> To avoid leaking host MSR state into guests, guest LSTAR, STAR and >> SYSCALL_MASK state is unconditionally loaded when switching into guest >> context. >> >> Attempting to dirty-track the state is pointless; host state is

Re: [Xen-devel] [PATCH 4/4] x86/vmx: Drop vmx_msr_state infrastructure

2017-02-13 Thread Jan Beulich
>>> On 13.02.17 at 15:32, wrote: > To avoid leaking host MSR state into guests, guest LSTAR, STAR and > SYSCALL_MASK state is unconditionally loaded when switching into guest > context. > > Attempting to dirty-track the state is pointless; host state is always > restoring upon exit from guest con

[Xen-devel] [PATCH 4/4] x86/vmx: Drop vmx_msr_state infrastructure

2017-02-13 Thread Andrew Cooper
To avoid leaking host MSR state into guests, guest LSTAR, STAR and SYSCALL_MASK state is unconditionally loaded when switching into guest context. Attempting to dirty-track the state is pointless; host state is always restoring upon exit from guest context, meaning that guest state is always consi