Re: [Xen-devel] [PATCH 4/4] SVM: clean up svm_vmcb_isvalid()

2017-06-01 Thread Jan Beulich
>>> On 31.05.17 at 14:14, wrote: > On 31/05/17 08:23, Jan Beulich wrote: >> -if ((vmcb->_cr3 & 0x7) != 0) { >> -PRINTF("CR3: MBZ bits are set (%#"PRIx64")\n", vmcb->_cr3); >> -} >> -if ((vmcb->_efer & EFER_LMA) && (vmcb->_cr3 & 0xfe) != 0) { >> -PRINTF("CR3: MBZ bits ar

Re: [Xen-devel] [PATCH 4/4] SVM: clean up svm_vmcb_isvalid()

2017-05-31 Thread Boris Ostrovsky
On 05/31/2017 11:32 AM, Andrew Cooper wrote: > On 31/05/17 15:50, Boris Ostrovsky wrote: >> On 05/31/2017 08:14 AM, Andrew Cooper wrote: >>> On 31/05/17 08:23, Jan Beulich wrote: - correct CR3 and CR4 checks - add vcpu parameter (to include in log messages) and constify vmcb one - us

Re: [Xen-devel] [PATCH 4/4] SVM: clean up svm_vmcb_isvalid()

2017-05-31 Thread Andrew Cooper
On 31/05/17 15:50, Boris Ostrovsky wrote: > On 05/31/2017 08:14 AM, Andrew Cooper wrote: >> On 31/05/17 08:23, Jan Beulich wrote: >>> - correct CR3 and CR4 checks >>> - add vcpu parameter (to include in log messages) and constify vmcb one >>> - use bool/true/false >>> - use accessors >>> - adjust f

Re: [Xen-devel] [PATCH 4/4] SVM: clean up svm_vmcb_isvalid()

2017-05-31 Thread Boris Ostrovsky
On 05/31/2017 08:14 AM, Andrew Cooper wrote: > On 31/05/17 08:23, Jan Beulich wrote: >> - correct CR3 and CR4 checks >> - add vcpu parameter (to include in log messages) and constify vmcb one >> - use bool/true/false >> - use accessors >> - adjust formatting >> >> Signed-off-by: Jan Beulich >> >>

Re: [Xen-devel] [PATCH 4/4] SVM: clean up svm_vmcb_isvalid()

2017-05-31 Thread Andrew Cooper
On 31/05/17 08:23, Jan Beulich wrote: > - correct CR3 and CR4 checks > - add vcpu parameter (to include in log messages) and constify vmcb one > - use bool/true/false > - use accessors > - adjust formatting > > Signed-off-by: Jan Beulich > > --- a/xen/arch/x86/hvm/svm/nestedsvm.c > +++ b/xen/arch/

[Xen-devel] [PATCH 4/4] SVM: clean up svm_vmcb_isvalid()

2017-05-31 Thread Jan Beulich
- correct CR3 and CR4 checks - add vcpu parameter (to include in log messages) and constify vmcb one - use bool/true/false - use accessors - adjust formatting Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/svm/nestedsvm.c +++ b/xen/arch/x86/hvm/svm/nestedsvm.c @@ -658,13 +658,13 @@ static int