Re: [Xen-devel] [PATCH 3/9] libxl: json string object can be NULL

2015-07-13 Thread Ian Jackson
Ian Campbell writes ("Re: [PATCH 3/9] libxl: json string object can be NULL"): > On Fri, 2015-07-10 at 19:00 +0100, Wei Liu wrote: > > Signed-off-by: Wei Liu > > Acked-by: Ian Campbell > > It occurs to me that since libxl__strdup can never return NULL due to > allocation failure we could consid

Re: [Xen-devel] [PATCH 3/9] libxl: json string object can be NULL

2015-07-13 Thread Ian Campbell
On Fri, 2015-07-10 at 19:00 +0100, Wei Liu wrote: > Signed-off-by: Wei Liu Acked-by: Ian Campbell It occurs to me that since libxl__strdup can never return NULL due to allocation failure we could consider make libxl__strdup(gc, NULL) be well defined as returning NULL. > --- > tools/libxl/libx

[Xen-devel] [PATCH 3/9] libxl: json string object can be NULL

2015-07-10 Thread Wei Liu
Signed-off-by: Wei Liu --- tools/libxl/libxl_json.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl_json.c b/tools/libxl/libxl_json.c index 346929a..652b3f4 100644 --- a/tools/libxl/libxl_json.c +++ b/tools/libxl/libxl_json.c @@ -433,8 +433,13 @@ int