Re: [Xen-devel] [PATCH 3/6] x86/vmx: Introduce and use struct vmx_msr_bitmap

2017-07-27 Thread Tian, Kevin
> From: Andrew Cooper [mailto:am...@hermes.cam.ac.uk] On Behalf Of > Andrew Cooper > > On 27/07/2017 07:02, Tian, Kevin wrote: > >> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > >> Sent: Wednesday, July 19, 2017 7:58 PM > >> > >> This avoids opencoding the bitmap bases in accessor funct

Re: [Xen-devel] [PATCH 3/6] x86/vmx: Introduce and use struct vmx_msr_bitmap

2017-07-27 Thread Andrew Cooper
On 27/07/2017 07:02, Tian, Kevin wrote: >> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] >> Sent: Wednesday, July 19, 2017 7:58 PM >> >> This avoids opencoding the bitmap bases in accessor functions. Introduce a >> build_assertions() function to check the structure layout against the manu

Re: [Xen-devel] [PATCH 3/6] x86/vmx: Introduce and use struct vmx_msr_bitmap

2017-07-26 Thread Tian, Kevin
> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Wednesday, July 19, 2017 7:58 PM > > This avoids opencoding the bitmap bases in accessor functions. Introduce a > build_assertions() function to check the structure layout against the manual > definiton. In addition, drop some stal

[Xen-devel] [PATCH 3/6] x86/vmx: Introduce and use struct vmx_msr_bitmap

2017-07-19 Thread Andrew Cooper
This avoids opencoding the bitmap bases in accessor functions. Introduce a build_assertions() function to check the structure layout against the manual definiton. In addition, drop some stale comments and ASSERT() that callers pass an in-range MSR. Signed-off-by: Andrew Cooper --- CC: Jan Beuli