Re: [Xen-devel] [PATCH 3/5] tools/libxc: don't send end record if remus fails

2015-12-30 Thread Wen Congyang
On 12/30/2015 07:11 PM, Andrew Cooper wrote: > On 30/12/2015 01:39, Wen Congyang wrote: >> Signed-off-by: Wen Congyang > > Reviewed-by: Andrew Cooper > > While looking at this code, what about error handling for the postcopy() > callback just out of context? We don't handle it now. IIRC, migr

Re: [Xen-devel] [PATCH 3/5] tools/libxc: don't send end record if remus fails

2015-12-30 Thread Andrew Cooper
On 30/12/2015 01:39, Wen Congyang wrote: Signed-off-by: Wen Congyang Reviewed-by: Andrew Cooper While looking at this code, what about error handling for the postcopy() callback just out of context? --- tools/libxc/xc_sr_save.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[Xen-devel] [PATCH 3/5] tools/libxc: don't send end record if remus fails

2015-12-29 Thread Wen Congyang
Signed-off-by: Wen Congyang --- tools/libxc/xc_sr_save.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxc/xc_sr_save.c b/tools/libxc/xc_sr_save.c index cefcef5..76ebb34 100644 --- a/tools/libxc/xc_sr_save.c +++ b/tools/libxc/xc_sr_save.c @@ -790,7 +790,7 @@ static i