>>> On 23.06.16 at 12:44, wrote:
> On 20/06/16 12:58, Jan Beulich wrote:
>> @@ -3845,10 +3834,11 @@ x86_emulate(
>> goto push;
>> case 7:
>> generate_exception_if(1, EXC_UD, -1);
>> -default:
>> -goto cannot_emulate;
>> }
>>
On 20/06/16 12:58, Jan Beulich wrote:
> @@ -3845,10 +3834,11 @@ x86_emulate(
> goto push;
> case 7:
> generate_exception_if(1, EXC_UD, -1);
> -default:
> -goto cannot_emulate;
> }
> break;
> +
> +default:
> +BUG();
There's no point in having default cases when all possible values have
respective case statements, or when there's just a "break" statement.
Otoh the two main switch() statements better get default cases added,
just to cover the case of someone altering one of the two lookup arrays
without suitabl
