Re: [Xen-devel] [PATCH 3/4] x86/traps: undo the PVHv1 bodge in NMI delivery path

2017-03-17 Thread Roger Pau Monné
On Fri, Mar 17, 2017 at 11:29:38AM +, Wei Liu wrote: > On Fri, Mar 17, 2017 at 05:26:07AM -0600, Jan Beulich wrote: > > >>> On 17.03.17 at 12:14, wrote: > > > --- a/xen/arch/x86/traps.c > > > +++ b/xen/arch/x86/traps.c > > > @@ -3537,7 +3537,7 @@ static void nmi_hwdom_report(unsigned int > >

Re: [Xen-devel] [PATCH 3/4] x86/traps: undo the PVHv1 bodge in NMI delivery path

2017-03-17 Thread Wei Liu
On Fri, Mar 17, 2017 at 11:31:45AM +, Andrew Cooper wrote: > On 17/03/17 11:29, Wei Liu wrote: > > On Fri, Mar 17, 2017 at 05:26:07AM -0600, Jan Beulich wrote: > > On 17.03.17 at 12:14, wrote: > >>> --- a/xen/arch/x86/traps.c > >>> +++ b/xen/arch/x86/traps.c > >>> @@ -3537,7 +3537,7 @@ sta

Re: [Xen-devel] [PATCH 3/4] x86/traps: undo the PVHv1 bodge in NMI delivery path

2017-03-17 Thread Andrew Cooper
On 17/03/17 11:29, Wei Liu wrote: > On Fri, Mar 17, 2017 at 05:26:07AM -0600, Jan Beulich wrote: > On 17.03.17 at 12:14, wrote: >>> --- a/xen/arch/x86/traps.c >>> +++ b/xen/arch/x86/traps.c >>> @@ -3537,7 +3537,7 @@ static void nmi_hwdom_report(unsigned int reason_idx) >>> { >>> struct d

Re: [Xen-devel] [PATCH 3/4] x86/traps: undo the PVHv1 bodge in NMI delivery path

2017-03-17 Thread Wei Liu
On Fri, Mar 17, 2017 at 05:26:07AM -0600, Jan Beulich wrote: > >>> On 17.03.17 at 12:14, wrote: > > --- a/xen/arch/x86/traps.c > > +++ b/xen/arch/x86/traps.c > > @@ -3537,7 +3537,7 @@ static void nmi_hwdom_report(unsigned int reason_idx) > > { > > struct domain *d = hardware_domain; > > >

Re: [Xen-devel] [PATCH 3/4] x86/traps: undo the PVHv1 bodge in NMI delivery path

2017-03-17 Thread Jan Beulich
>>> On 17.03.17 at 12:14, wrote: > --- a/xen/arch/x86/traps.c > +++ b/xen/arch/x86/traps.c > @@ -3537,7 +3537,7 @@ static void nmi_hwdom_report(unsigned int reason_idx) > { > struct domain *d = hardware_domain; > > -if ( !d || !d->vcpu || !d->vcpu[0] || !is_pv_domain(d) /* PVH fixme */

Re: [Xen-devel] [PATCH 3/4] x86/traps: undo the PVHv1 bodge in NMI delivery path

2017-03-17 Thread Roger Pau Monné
On Fri, Mar 17, 2017 at 11:10:19AM +, Wei Liu wrote: > On Fri, Mar 17, 2017 at 11:06:41AM +, Andrew Cooper wrote: > > On 17/03/17 11:02, Wei Liu wrote: > > > A bodge was added in 21c9fce8efb to skip delivering NMI to PVHv1 guest. > > > Now that PVHv1 is gone, undo that bodge and remove the

Re: [Xen-devel] [PATCH 3/4] x86/traps: undo the PVHv1 bodge in NMI delivery path

2017-03-17 Thread Wei Liu
On Fri, Mar 17, 2017 at 11:11:17AM +, Andrew Cooper wrote: > On 17/03/17 11:10, Wei Liu wrote: > > On Fri, Mar 17, 2017 at 11:06:41AM +, Andrew Cooper wrote: > >> On 17/03/17 11:02, Wei Liu wrote: > >>> A bodge was added in 21c9fce8efb to skip delivering NMI to PVHv1 guest. > >>> Now that P

Re: [Xen-devel] [PATCH 3/4] x86/traps: undo the PVHv1 bodge in NMI delivery path

2017-03-17 Thread Andrew Cooper
On 17/03/17 11:10, Wei Liu wrote: > On Fri, Mar 17, 2017 at 11:06:41AM +, Andrew Cooper wrote: >> On 17/03/17 11:02, Wei Liu wrote: >>> A bodge was added in 21c9fce8efb to skip delivering NMI to PVHv1 guest. >>> Now that PVHv1 is gone, undo that bodge and remove the fixme. >>> >>> Signed-off-by

Re: [Xen-devel] [PATCH 3/4] x86/traps: undo the PVHv1 bodge in NMI delivery path

2017-03-17 Thread Wei Liu
On Fri, Mar 17, 2017 at 11:06:41AM +, Andrew Cooper wrote: > On 17/03/17 11:02, Wei Liu wrote: > > A bodge was added in 21c9fce8efb to skip delivering NMI to PVHv1 guest. > > Now that PVHv1 is gone, undo that bodge and remove the fixme. > > > > Signed-off-by: Wei Liu > > This unfortunately ne

Re: [Xen-devel] [PATCH 3/4] x86/traps: undo the PVHv1 bodge in NMI delivery path

2017-03-17 Thread Andrew Cooper
On 17/03/17 11:02, Wei Liu wrote: > A bodge was added in 21c9fce8efb to skip delivering NMI to PVHv1 guest. > Now that PVHv1 is gone, undo that bodge and remove the fixme. > > Signed-off-by: Wei Liu This unfortunately needs to stay, although perhaps it wants rewording. send_guest_trap() just out

[Xen-devel] [PATCH 3/4] x86/traps: undo the PVHv1 bodge in NMI delivery path

2017-03-17 Thread Wei Liu
A bodge was added in 21c9fce8efb to skip delivering NMI to PVHv1 guest. Now that PVHv1 is gone, undo that bodge and remove the fixme. Signed-off-by: Wei Liu --- xen/arch/x86/traps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c in