Re: [Xen-devel] [PATCH 3/4] x86/mce: Translate passed-in GPA to host machine address

2015-09-15 Thread Haozhong Zhang
On Tue, Sep 15, 2015 at 02:50:27PM +0100, Andrew Cooper wrote: > On 15/09/15 14:42, Haozhong Zhang wrote: > > > >>> +mfn = mfn_x(get_gfn(d, gpfn, &t)); > >>> + > >>> +if (mfn == INVALID_MFN) { > >>> +put_domain(d); > >>> +retur

Re: [Xen-devel] [PATCH 3/4] x86/mce: Translate passed-in GPA to host machine address

2015-09-15 Thread Andrew Cooper
On 15/09/15 14:42, Haozhong Zhang wrote: > >>> +mfn = mfn_x(get_gfn(d, gpfn, &t)); >>> + >>> +if (mfn == INVALID_MFN) { >>> +put_domain(d); >>> +return x86_mcerr("do_mca inject: illegal MSR value", >>> +

Re: [Xen-devel] [PATCH 3/4] x86/mce: Translate passed-in GPA to host machine address

2015-09-15 Thread Haozhong Zhang
On Tue, Sep 15, 2015 at 07:47:49AM -0600, Jan Beulich wrote: > >>> On 15.09.15 at 15:42, wrote: > > On Tue, Sep 15, 2015 at 07:24:34AM -0600, Jan Beulich wrote: > >> >>> On 15.09.15 at 10:29, wrote: > >> > +mfn = mfn_x(get_gfn(d, gpfn, &t)); > >> > + > >> > +if (mf

Re: [Xen-devel] [PATCH 3/4] x86/mce: Translate passed-in GPA to host machine address

2015-09-15 Thread Jan Beulich
>>> On 15.09.15 at 15:42, wrote: > On Tue, Sep 15, 2015 at 07:24:34AM -0600, Jan Beulich wrote: >> >>> On 15.09.15 at 10:29, wrote: >> > +mfn = mfn_x(get_gfn(d, gpfn, &t)); >> > + >> > +if (mfn == INVALID_MFN) { >> > +put_domain(d); >> > +

Re: [Xen-devel] [PATCH 3/4] x86/mce: Translate passed-in GPA to host machine address

2015-09-15 Thread Haozhong Zhang
On Tue, Sep 15, 2015 at 07:24:34AM -0600, Jan Beulich wrote: > >>> On 15.09.15 at 10:29, wrote: > > @@ -1422,6 +1423,38 @@ long do_mca(XEN_GUEST_HANDLE_PARAM(xen_mc_t) > > u_xen_mc) > > if (mc_msrinject->mcinj_count == 0) > > return 0; > > > > +if (mc_msrinject->mcin

Re: [Xen-devel] [PATCH 3/4] x86/mce: Translate passed-in GPA to host machine address

2015-09-15 Thread Jan Beulich
>>> On 15.09.15 at 10:29, wrote: > @@ -1422,6 +1423,38 @@ long do_mca(XEN_GUEST_HANDLE_PARAM(xen_mc_t) u_xen_mc) > if (mc_msrinject->mcinj_count == 0) > return 0; > > +if (mc_msrinject->mcinj_flags & MC_MSRINJ_F_GPADDR) { Perhaps you earlier patch fixing coding sty

Re: [Xen-devel] [PATCH 3/4] x86/mce: Translate passed-in GPA to host machine address

2015-09-15 Thread Haozhong Zhang
On Tue, Sep 15, 2015 at 11:14:26AM +0200, Egger, Christoph wrote: > On 2015/09/15 10:29, Haozhong Zhang wrote: > > This patch adds a new flag MC_MSRINJ_F_GPADDR to > > xen_mc_msrinject.mcinj_flags, and makes do_mca() to translate the > > guest physical address passed-in through > > xen_mc_msrinject

Re: [Xen-devel] [PATCH 3/4] x86/mce: Translate passed-in GPA to host machine address

2015-09-15 Thread Egger, Christoph
On 2015/09/15 10:29, Haozhong Zhang wrote: > This patch adds a new flag MC_MSRINJ_F_GPADDR to > xen_mc_msrinject.mcinj_flags, and makes do_mca() to translate the > guest physical address passed-in through > xen_mc_msrinject.mcinj_msr[i].value to the host machine address if > this flag is present. >

[Xen-devel] [PATCH 3/4] x86/mce: Translate passed-in GPA to host machine address

2015-09-15 Thread Haozhong Zhang
This patch adds a new flag MC_MSRINJ_F_GPADDR to xen_mc_msrinject.mcinj_flags, and makes do_mca() to translate the guest physical address passed-in through xen_mc_msrinject.mcinj_msr[i].value to the host machine address if this flag is present. Signed-off-by: Haozhong Zhang --- xen/arch/x86/cpu/