Re: [Xen-devel] [PATCH 3/4] mm: Don't request scrubbing until dom0 is running

2017-08-29 Thread Jan Beulich
>>> On 29.08.17 at 16:20, wrote: >> Yes, but please consider the "#define boot_scrub_done 0" approach >> too. > > Yes, I'll do that but I will rename boot_scrub_done to scrub_debug since > having boot_scrub_done=0 in non-debug case will not convey what it > actually is supposed to mean. Yeah, I

Re: [Xen-devel] [PATCH 3/4] mm: Don't request scrubbing until dom0 is running

2017-08-29 Thread Boris Ostrovsky
> Yes, but please consider the "#define boot_scrub_done 0" approach > too. Yes, I'll do that but I will rename boot_scrub_done to scrub_debug since having boot_scrub_done=0 in non-debug case will not convey what it actually is supposed to mean. -boris __

Re: [Xen-devel] [PATCH 3/4] mm: Don't request scrubbing until dom0 is running

2017-08-29 Thread Jan Beulich
>>> On 29.08.17 at 15:27, wrote: > On 08/29/2017 09:22 AM, Jan Beulich wrote: > On 29.08.17 at 13:56, wrote: >>> On Mon, Aug 28, 2017 at 04:40:28PM -0400, Boris Ostrovsky wrote: There is no need to scrub pages freed during dom0 construction since heap will be scrubbed once dom0 is r

Re: [Xen-devel] [PATCH 3/4] mm: Don't request scrubbing until dom0 is running

2017-08-29 Thread Jan Beulich
>>> On 28.08.17 at 22:40, wrote: > --- a/xen/common/page_alloc.c > +++ b/xen/common/page_alloc.c > @@ -2259,7 +2259,7 @@ void free_domheap_pages(struct page_info *pg, unsigned > int order) > */ > scrub = !!d->is_dying; > #else > -scrub = true; > +

Re: [Xen-devel] [PATCH 3/4] mm: Don't request scrubbing until dom0 is running

2017-08-29 Thread Wei Liu
On Tue, Aug 29, 2017 at 07:26:28AM -0600, Jan Beulich wrote: > >>> On 28.08.17 at 22:40, wrote: > > --- a/xen/common/page_alloc.c > > +++ b/xen/common/page_alloc.c > > @@ -2259,7 +2259,7 @@ void free_domheap_pages(struct page_info *pg, > > unsigned int order) > > */ > >

Re: [Xen-devel] [PATCH 3/4] mm: Don't request scrubbing until dom0 is running

2017-08-29 Thread Boris Ostrovsky
On 08/29/2017 09:22 AM, Jan Beulich wrote: On 29.08.17 at 13:56, wrote: >> On Mon, Aug 28, 2017 at 04:40:28PM -0400, Boris Ostrovsky wrote: >>> There is no need to scrub pages freed during dom0 construction >>> since heap will be scrubbed once dom0 is ready (by scrub_heap_pages()). >>> >>> Si

Re: [Xen-devel] [PATCH 3/4] mm: Don't request scrubbing until dom0 is running

2017-08-29 Thread Jan Beulich
>>> On 29.08.17 at 13:56, wrote: > On Mon, Aug 28, 2017 at 04:40:28PM -0400, Boris Ostrovsky wrote: >> There is no need to scrub pages freed during dom0 construction >> since heap will be scrubbed once dom0 is ready (by scrub_heap_pages()). >> >> Since boot_scrub_done will not be set if boot-time

Re: [Xen-devel] [PATCH 3/4] mm: Don't request scrubbing until dom0 is running

2017-08-29 Thread Wei Liu
On Mon, Aug 28, 2017 at 04:40:28PM -0400, Boris Ostrovsky wrote: > There is no need to scrub pages freed during dom0 construction > since heap will be scrubbed once dom0 is ready (by scrub_heap_pages()). > > Since boot_scrub_done will not be set if boot-time scrubbing is off we > also check for do

[Xen-devel] [PATCH 3/4] mm: Don't request scrubbing until dom0 is running

2017-08-28 Thread Boris Ostrovsky
There is no need to scrub pages freed during dom0 construction since heap will be scrubbed once dom0 is ready (by scrub_heap_pages()). Since boot_scrub_done will not be set if boot-time scrubbing is off we also check for domain state. Signed-off-by: Boris Ostrovsky --- xen/common/page_alloc.c |