Re: [Xen-devel] [PATCH 3/4] gdbsx: prefer privcmd character device

2015-11-25 Thread Ian Jackson
Doug Goldstein writes ("Re: [PATCH 3/4] gdbsx: prefer privcmd character device"): > I agree. I actually emailed the maintainer about this but his address > bounced so I left it as the simpler patch instead. I can make that > chance and resubmit if you'd prefer. Yes, please, thanks! Ian. ___

Re: [Xen-devel] [PATCH 3/4] gdbsx: prefer privcmd character device

2015-11-25 Thread Ian Campbell
On Tue, 2015-11-24 at 18:53 +, Ian Jackson wrote: > Doug Goldstein writes ("[PATCH 3/4] gdbsx: prefer privcmd character > device"): > > Prefer using the character device over the proc file if the character > > device exists. > > I think this common logic (which also appears in your 1/4 patch)

Re: [Xen-devel] [PATCH 3/4] gdbsx: prefer privcmd character device

2015-11-24 Thread Doug Goldstein
On 11/24/15 1:19 PM, Doug Goldstein wrote: > On 11/24/15 12:53 PM, Ian Jackson wrote: >> Doug Goldstein writes ("[PATCH 3/4] gdbsx: prefer privcmd character device"): >>> Prefer using the character device over the proc file if the character >>> device exists. >> >> I think this common logic (which

Re: [Xen-devel] [PATCH 3/4] gdbsx: prefer privcmd character device

2015-11-24 Thread Doug Goldstein
On 11/24/15 12:53 PM, Ian Jackson wrote: > Doug Goldstein writes ("[PATCH 3/4] gdbsx: prefer privcmd character device"): >> Prefer using the character device over the proc file if the character >> device exists. > > I think this common logic (which also appears in your 1/4 patch) > should be facto

Re: [Xen-devel] [PATCH 3/4] gdbsx: prefer privcmd character device

2015-11-24 Thread Ian Jackson
Doug Goldstein writes ("[PATCH 3/4] gdbsx: prefer privcmd character device"): > Prefer using the character device over the proc file if the character > device exists. I think this common logic (which also appears in your 1/4 patch) should be factored out. Could gdbsx not use a libxc handle ? Ian

[Xen-devel] [PATCH 3/4] gdbsx: prefer privcmd character device

2015-11-24 Thread Doug Goldstein
Prefer using the character device over the proc file if the character device exists. CC: Mukesh Rathor CC: Ian Jackson CC: Stefano Stabellini CC: Ian Campbell CC: Wei Liu Signed-off-by: Doug Goldstein --- tools/debugger/gdbsx/xg/xg_main.c | 8 +--- 1 file changed, 5 insertions(+), 3 del