Re: [Xen-devel] [PATCH 3/3] xl: create: close restore_fd_to_close on error

2016-02-19 Thread Ian Jackson
Ian Campbell writes ("[PATCH 3/3] xl: create: close restore_fd_to_close on error"): > Currently the fd is opened and then later closed and > restore_fd_to_close set back to -1, however there are several goto out > and goto error_out paths in the interim. > > Since the code resets restore_fd_to_cl

[Xen-devel] [PATCH 3/3] xl: create: close restore_fd_to_close on error

2016-02-17 Thread Ian Campbell
Currently the fd is opened and then later closed and restore_fd_to_close set back to -1, however there are several goto out and goto error_out paths in the interim. Since the code resets restore_fd_to_close to -1 it is OK to check this and close on the out path too. CID: 1055897 Signed-off-by: I