Re: [Xen-devel] [PATCH 3/3] x86/mm: merge ptwr and mmio_ro page fault handlers

2017-08-31 Thread Wei Liu
On Wed, Aug 30, 2017 at 07:02:52PM +0100, Andrew Cooper wrote: > On 30/08/17 18:11, Wei Liu wrote: > > Provide a unified entry to avoid going through pte look-up, decode and > > emulation cycle more than necessary. The path taken is determined by > > the faulting address. > > > > Note that the orde

Re: [Xen-devel] [PATCH 3/3] x86/mm: merge ptwr and mmio_ro page fault handlers

2017-08-30 Thread Andrew Cooper
On 30/08/17 18:11, Wei Liu wrote: > Provide a unified entry to avoid going through pte look-up, decode and > emulation cycle more than necessary. The path taken is determined by > the faulting address. > > Note that the order of checks is changed in the new function, but the > order of the checks i

[Xen-devel] [PATCH 3/3] x86/mm: merge ptwr and mmio_ro page fault handlers

2017-08-30 Thread Wei Liu
Provide a unified entry to avoid going through pte look-up, decode and emulation cycle more than necessary. The path taken is determined by the faulting address. Note that the order of checks is changed in the new function, but the order of the checks is performed shouldn't matter. The sole calle