Re: [Xen-devel] [PATCH 3/3] x86/HVM: prefer structure assignment for seg reg copying

2016-12-06 Thread Boris Ostrovsky
On 12/06/2016 06:45 AM, Jan Beulich wrote: > This makes things type safe. > > Signed-off-by: Jan Beulich Reviewed-by: Boris Ostrovsky ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 3/3] x86/HVM: prefer structure assignment for seg reg copying

2016-12-06 Thread Andrew Cooper
On 06/12/16 11:45, Jan Beulich wrote: > This makes things type safe. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

[Xen-devel] [PATCH 3/3] x86/HVM: prefer structure assignment for seg reg copying

2016-12-06 Thread Jan Beulich
This makes things type safe. Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/emulate.c +++ b/xen/arch/x86/hvm/emulate.c @@ -1434,7 +1434,8 @@ static int hvmemul_read_segment( if ( IS_ERR(sreg) ) return -PTR_ERR(sreg); -memcpy(reg, sreg, sizeof(struct segment_register)); +

Re: [Xen-devel] [PATCH 3/3] x86/HVM: prefer structure assignment for seg reg copying

2016-12-06 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 06 December 2016 11:45 > To: xen-devel > Cc: Suravee Suthikulpanit ; Andrew > Cooper ; Paul Durrant > ; George Dunlap ; > Boris Ostrovsky > Subject: [PATCH 3/3] x86/HVM: prefer structure assignment for seg reg > c