Re: [Xen-devel] [PATCH 3/3] tools/libxl: run_helper - add #define for arguments.

2016-02-03 Thread Ian Campbell
On Tue, 2016-01-26 at 16:25 +, Ian Jackson wrote: > Ian Campbell writes ("Re: [PATCH 3/3] tools/libxl: run_helper - add > #define for arguments."): > > On Mon, 2016-01-25 at 16:06 -0500, Konrad Rzeszutek Wilk wrote: > > > Describe what the four (or more in the future) arguments > > > are for. >

Re: [Xen-devel] [PATCH 3/3] tools/libxl: run_helper - add #define for arguments.

2016-01-26 Thread Ian Jackson
Ian Campbell writes ("Re: [PATCH 3/3] tools/libxl: run_helper - add #define for arguments."): > On Mon, 2016-01-25 at 16:06 -0500, Konrad Rzeszutek Wilk wrote: > > Describe what the four (or more in the future) arguments > > are for. > > I'd say that a code comment on the definition would be suff

Re: [Xen-devel] [PATCH 3/3] tools/libxl: run_helper - add #define for arguments.

2016-01-26 Thread Ian Campbell
On Mon, 2016-01-25 at 16:06 -0500, Konrad Rzeszutek Wilk wrote: > Describe what the four (or more in the future) arguments > are for. I'd say that a code comment on the definition would be sufficient here, but I'll defer to Ian J as author of this code. > > Signed-off-by: Konrad Rzeszutek Wilk

[Xen-devel] [PATCH 3/3] tools/libxl: run_helper - add #define for arguments.

2016-01-25 Thread Konrad Rzeszutek Wilk
Describe what the four (or more in the future) arguments are for. Signed-off-by: Konrad Rzeszutek Wilk --- tools/libxl/libxl_save_callout.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/tools/libxl/libxl_save_callout.c b/tools/libxl/libxl_save_callout.c index 3a