Re: [Xen-devel] [PATCH 3/3] libxl: Domain destroy: fork

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 09:14 -0600, Jim Fehlig wrote: > Ian Campbell wrote: > > On Tue, 2015-03-17 at 09:30 -0600, Jim Fehlig wrote: > > > >> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c > >> index b6541d4..b43db1a 100644 > >> --- a/tools/libxl/libxl.c > >> +++ b/tools/libxl/libxl.c > >

Re: [Xen-devel] [PATCH 3/3] libxl: Domain destroy: fork

2015-03-20 Thread Jim Fehlig
Ian Campbell wrote: > On Tue, 2015-03-17 at 09:30 -0600, Jim Fehlig wrote: > >> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c >> index b6541d4..b43db1a 100644 >> --- a/tools/libxl/libxl.c >> +++ b/tools/libxl/libxl.c >> @@ -1481,6 +1481,10 @@ static void domain_destroy_callback(libxl__e

Re: [Xen-devel] [PATCH 3/3] libxl: Domain destroy: fork

2015-03-18 Thread Ian Campbell
On Tue, 2015-03-17 at 18:04 +, Wei Liu wrote: > > +} else { > > +LOGE(ERROR, > > + "xc_domain_destroy failed for %d (with difficult errno value %d)", > > Indentation is wrong. It is preferable to pull back the indentation of a string literal rather than wrap it in order to

Re: [Xen-devel] [PATCH 3/3] libxl: Domain destroy: fork

2015-03-18 Thread Ian Campbell
On Tue, 2015-03-17 at 09:30 -0600, Jim Fehlig wrote: > From: Ian Jackson > > Call xc_domain_destroy in a subprocess. That allows us to do so > asynchronously, rather than blocking the whole process calling libxl. > > The changes in detail: > > * Provide an libxl__ev_child in libxl__domain_des

Re: [Xen-devel] [PATCH 3/3] libxl: Domain destroy: fork

2015-03-17 Thread Wei Liu
On Tue, Mar 17, 2015 at 09:30:59AM -0600, Jim Fehlig wrote: > From: Ian Jackson > > Call xc_domain_destroy in a subprocess. That allows us to do so > asynchronously, rather than blocking the whole process calling libxl. > > The changes in detail: > > * Provide an libxl__ev_child in libxl__dom

[Xen-devel] [PATCH 3/3] libxl: Domain destroy: fork

2015-03-17 Thread Jim Fehlig
From: Ian Jackson Call xc_domain_destroy in a subprocess. That allows us to do so asynchronously, rather than blocking the whole process calling libxl. The changes in detail: * Provide an libxl__ev_child in libxl__domain_destroy_state, and initialise it in libxl__domain_destroy. There is