Re: [Xen-devel] [PATCH 20/29] xl: split out cd related code

2017-02-27 Thread Wei Liu
On Mon, Feb 27, 2017 at 04:44:53PM +, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH 20/29] xl: split out cd related code"): > > On Mon, Feb 27, 2017 at 04:36:16PM +, Ian Jackson wrote: > > > Yes, indeed, that was the only reason I didn't ack it. > > > > Thanks. I want to avoid repostin

Re: [Xen-devel] [PATCH 20/29] xl: split out cd related code

2017-02-27 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH 20/29] xl: split out cd related code"): > On Mon, Feb 27, 2017 at 04:36:16PM +, Ian Jackson wrote: > > Yes, indeed, that was the only reason I didn't ack it. > > Thanks. I want to avoid reposting as much as possible because this > series is really long and tedious.

Re: [Xen-devel] [PATCH 20/29] xl: split out cd related code

2017-02-27 Thread Wei Liu
On Mon, Feb 27, 2017 at 04:36:16PM +, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH 20/29] xl: split out cd related code"): > > On Mon, Feb 27, 2017 at 03:56:21PM +, Ian Jackson wrote: > > > Wei Liu writes ("[PATCH 20/29] xl: split out cd related code"): > > > > Signed-off-by: Wei Liu >

Re: [Xen-devel] [PATCH 20/29] xl: split out cd related code

2017-02-27 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH 20/29] xl: split out cd related code"): > On Mon, Feb 27, 2017 at 03:56:21PM +, Ian Jackson wrote: > > Wei Liu writes ("[PATCH 20/29] xl: split out cd related code"): > > > Signed-off-by: Wei Liu > > > --- > > > tools/xl/Makefile | 2 +- > > > tools/xl/xl_cd.

Re: [Xen-devel] [PATCH 20/29] xl: split out cd related code

2017-02-27 Thread Wei Liu
On Mon, Feb 27, 2017 at 03:56:21PM +, Ian Jackson wrote: > Wei Liu writes ("[PATCH 20/29] xl: split out cd related code"): > > Signed-off-by: Wei Liu > > --- > > tools/xl/Makefile | 2 +- > > tools/xl/xl_cd.c | 114 > > ++ > > Would

Re: [Xen-devel] [PATCH 20/29] xl: split out cd related code

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 20/29] xl: split out cd related code"): > Signed-off-by: Wei Liu > --- > tools/xl/Makefile | 2 +- > tools/xl/xl_cd.c | 114 > ++ Would you mind calling this `libxl_cdrom.c' rather than `_cd' ? The latter makes me

[Xen-devel] [PATCH 20/29] xl: split out cd related code

2017-02-24 Thread Wei Liu
Signed-off-by: Wei Liu --- tools/xl/Makefile | 2 +- tools/xl/xl_cd.c | 114 ++ tools/xl/xl_cmdimpl.c | 80 --- 3 files changed, 115 insertions(+), 81 deletions(-) create mode 100644 tools/xl/xl_cd.c dif