Re: [Xen-devel] [PATCH 20/27] tools/libxl: Infrastructure for writing a v2 stream

2015-07-10 Thread Ian Campbell
On Fri, 2015-07-10 at 12:03 +0100, Andrew Cooper wrote: > On 10/07/15 11:55, Ian Campbell wrote: > > On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote: > >> +void libxl__stream_write_start(libxl__egc *egc, > >> + libxl__stream_write_state *stream) > >> +{ > >> +

Re: [Xen-devel] [PATCH 20/27] tools/libxl: Infrastructure for writing a v2 stream

2015-07-10 Thread Andrew Cooper
On 10/07/15 11:55, Ian Campbell wrote: > On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote: >> +void libxl__stream_write_start(libxl__egc *egc, >> + libxl__stream_write_state *stream) >> +{ >> +libxl__datacopier_state *dc = &stream->dc; >> +STATE_AO_GC(str

Re: [Xen-devel] [PATCH 20/27] tools/libxl: Infrastructure for writing a v2 stream

2015-07-10 Thread Ian Campbell
On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote: > +void libxl__stream_write_start(libxl__egc *egc, > + libxl__stream_write_state *stream) > +{ > +libxl__datacopier_state *dc = &stream->dc; > +STATE_AO_GC(stream->ao); > +struct libxl_sr_hdr hdr = { 0

Re: [Xen-devel] [PATCH 20/27] tools/libxl: Infrastructure for writing a v2 stream

2015-06-17 Thread Wen Congyang
On 06/15/2015 09:44 PM, Andrew Cooper wrote: > From: Ross Lagerwall > > Signed-off-by: Ross Lagerwall > Signed-off-by: Andrew Cooper > CC: Ian Campbell > CC: Ian Jackson > CC: Wei Liu > --- > tools/libxl/Makefile |2 +- > tools/libxl/libxl_internal.h | 33 +++ > tools/

Re: [Xen-devel] [PATCH 20/27] tools/libxl: Infrastructure for writing a v2 stream

2015-06-17 Thread Andrew Cooper
On 17/06/15 02:31, Yang Hongyang wrote: >> +default: >> +ret = ERROR_FAIL; >> +goto err; >> +} >> + >> +ret = libxl__domain_suspend_device_model(gc, dss); > > This is no longer needed, the suspend callback already called > this function and the emulator context already s

Re: [Xen-devel] [PATCH 20/27] tools/libxl: Infrastructure for writing a v2 stream

2015-06-17 Thread Yang Hongyang
On 06/15/2015 09:44 PM, Andrew Cooper wrote: [...] + +static void stream_success(libxl__egc *egc, + libxl__stream_write_state *stream); +static void stream_failed(libxl__egc *egc, + libxl__stream_write_state *stream, int ret); +static void stre

Re: [Xen-devel] [PATCH 20/27] tools/libxl: Infrastructure for writing a v2 stream

2015-06-16 Thread Wen Congyang
On 06/15/2015 09:44 PM, Andrew Cooper wrote: > From: Ross Lagerwall > > Signed-off-by: Ross Lagerwall > Signed-off-by: Andrew Cooper > CC: Ian Campbell > CC: Ian Jackson > CC: Wei Liu > --- > tools/libxl/Makefile |2 +- > tools/libxl/libxl_internal.h | 33 +++ > tools/

Re: [Xen-devel] [PATCH 20/27] tools/libxl: Infrastructure for writing a v2 stream

2015-06-16 Thread Wen Congyang
On 06/15/2015 09:44 PM, Andrew Cooper wrote: > From: Ross Lagerwall > > Signed-off-by: Ross Lagerwall > Signed-off-by: Andrew Cooper > CC: Ian Campbell > CC: Ian Jackson > CC: Wei Liu > --- > tools/libxl/Makefile |2 +- > tools/libxl/libxl_internal.h | 33 +++ > tools/

Re: [Xen-devel] [PATCH 20/27] tools/libxl: Infrastructure for writing a v2 stream

2015-06-16 Thread Yang Hongyang
On 06/15/2015 09:44 PM, Andrew Cooper wrote: [...] + +static void write_emulator_record(libxl__egc *egc, + libxl__stream_write_state *stream) +{ +libxl__domain_suspend_state *dss = CONTAINER_OF(stream, *dss, sws); +libxl__datacopier_state *dc = &stream->

Re: [Xen-devel] [PATCH 20/27] tools/libxl: Infrastructure for writing a v2 stream

2015-06-16 Thread Andrew Cooper
On 16/06/15 15:57, Ian Campbell wrote: > On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote: >> From: Ross Lagerwall >> >> Signed-off-by: Ross Lagerwall >> Signed-off-by: Andrew Cooper >> CC: Ian Campbell >> CC: Ian Jackson >> CC: Wei Liu >> --- >> tools/libxl/Makefile |2

Re: [Xen-devel] [PATCH 20/27] tools/libxl: Infrastructure for writing a v2 stream

2015-06-16 Thread Ian Campbell
On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote: > From: Ross Lagerwall > > Signed-off-by: Ross Lagerwall > Signed-off-by: Andrew Cooper > CC: Ian Campbell > CC: Ian Jackson > CC: Wei Liu > --- > tools/libxl/Makefile |2 +- > tools/libxl/libxl_internal.h | 33 ++

[Xen-devel] [PATCH 20/27] tools/libxl: Infrastructure for writing a v2 stream

2015-06-15 Thread Andrew Cooper
From: Ross Lagerwall Signed-off-by: Ross Lagerwall Signed-off-by: Andrew Cooper CC: Ian Campbell CC: Ian Jackson CC: Wei Liu --- tools/libxl/Makefile |2 +- tools/libxl/libxl_internal.h | 33 +++ tools/libxl/libxl_stream_write.c | 536 +