Re: [Xen-devel] [PATCH 2/8] xen/misc: Remove or annotate possibly-unused functions

2016-02-10 Thread Andrew Cooper
On 10/02/16 13:06, Jan Beulich wrote: On 09.02.16 at 21:01, wrote: >> --- a/xen/common/rcupdate.c >> +++ b/xen/common/rcupdate.c >> @@ -141,12 +141,6 @@ static inline int rcu_batch_before(long a, long b) >> return (a - b) < 0; >> } >> >> -/* Is batch a after batch b ? */ >> -static in

Re: [Xen-devel] [PATCH 2/8] xen/misc: Remove or annotate possibly-unused functions

2016-02-10 Thread Jan Beulich
>>> On 09.02.16 at 21:01, wrote: > --- a/xen/common/rcupdate.c > +++ b/xen/common/rcupdate.c > @@ -141,12 +141,6 @@ static inline int rcu_batch_before(long a, long b) > return (a - b) < 0; > } > > -/* Is batch a after batch b ? */ > -static inline int rcu_batch_after(long a, long b) > -{ >

Re: [Xen-devel] [PATCH 2/8] xen/misc: Remove or annotate possibly-unused functions

2016-02-10 Thread Tim Deegan
At 20:01 + on 09 Feb (1455048102), Andrew Cooper wrote: > Clang notices more unused functions than GCC. > > * sh_next_page() is only used at GUEST_PAGING_LEVELS=2, so remove it from the >other guest level translation units > * rcu_batch_after() is completely unused. > * Various of the C

[Xen-devel] [PATCH 2/8] xen/misc: Remove or annotate possibly-unused functions

2016-02-09 Thread Andrew Cooper
Clang notices more unused functions than GCC. * sh_next_page() is only used at GUEST_PAGING_LEVELS=2, so remove it from the other guest level translation units * rcu_batch_after() is completely unused. * Various of the COMPAT() generated functions are used only for their BUILD_BUG_ON() pr