Re: [Xen-devel] [PATCH 2/5] libxc: Split off xc_minios_privcmd.c

2015-03-03 Thread Wei Liu
On Mon, Mar 02, 2015 at 05:31:53PM +, Ian Campbell wrote: > On Thu, 2015-02-26 at 11:56 +, Wei Liu wrote: > > From: Ian Jackson > > > > We are going to want to use some but not all of the machinery > > previously in xc_minios.c. Split the privcmd and gnttab code into its > > own file. >

Re: [Xen-devel] [PATCH 2/5] libxc: Split off xc_minios_privcmd.c

2015-03-02 Thread Ian Campbell
On Thu, 2015-02-26 at 11:56 +, Wei Liu wrote: > From: Ian Jackson > > We are going to want to use some but not all of the machinery > previously in xc_minios.c. Split the privcmd and gnttab code into its > own file. Does it make sense to put gnttab code in a file called privcmd.c? I don't

Re: [Xen-devel] [PATCH 2/5] libxc: Split off xc_minios_privcmd.c

2015-02-26 Thread Samuel Thibault
Wei Liu, le Thu 26 Feb 2015 11:56:18 +, a écrit : > We are going to want to use some but not all of the machinery > previously in xc_minios.c. Split the privcmd and gnttab code into its > own file. This part is pure code motion. > > But we also have to: > > - Alter the Makefile to build an

Re: [Xen-devel] [PATCH 2/5] libxc: Split off xc_minios_privcmd.c

2015-02-26 Thread Wei Liu
On Thu, Feb 26, 2015 at 11:56:18AM +, Wei Liu wrote: > From: Ian Jackson > > We are going to want to use some but not all of the machinery > previously in xc_minios.c. Split the privcmd and gnttab code into its > own file. This part is pure code motion. > > But we also have to: > > - Alt

[Xen-devel] [PATCH 2/5] libxc: Split off xc_minios_privcmd.c

2015-02-26 Thread Wei Liu
From: Ian Jackson We are going to want to use some but not all of the machinery previously in xc_minios.c. Split the privcmd and gnttab code into its own file. This part is pure code motion. But we also have to: - Alter the Makefile to build and link xc_minios_privcmd.c too. - Rename some