Re: [Xen-devel] [PATCH 2/4] x86: adjust xsave structure attributes

2016-01-29 Thread Andrew Cooper
On 29/01/16 10:27, Jan Beulich wrote: > The packed attribute was pointlessly used here - there are no > misaligned fields, and hence even if the attribute took effect, it > would at best lead to the compiler generating worse code. > > At the same time specify the required alignment of the fpu_sse s

[Xen-devel] [PATCH 2/4] x86: adjust xsave structure attributes

2016-01-29 Thread Jan Beulich
The packed attribute was pointlessly used here - there are no misaligned fields, and hence even if the attribute took effect, it would at best lead to the compiler generating worse code. At the same time specify the required alignment of the fpu_sse sub- structure, such that the various typeof() u