Re: [Xen-devel] [PATCH 2/3] x86/HVM: support (emulate) UMIP

2016-12-25 Thread Suravee Suthikulpanit
On 12/7/16 23:06, Andrew Cooper wrote: On 07/12/16 15:39, Jan Beulich wrote: On 07.12.16 at 16:31, wrote: On 12/07/2016 10:14 AM, Jan Beulich wrote: On 07.12.16 at 16:10, wrote: On 12/07/2016 06:29 AM, Jan Beulich wrote: On 06.12.16 at 17:23, wrote: On 12/06/2016 06:44 AM, Jan Beulich wr

Re: [Xen-devel] [PATCH 2/3] x86/HVM: support (emulate) UMIP

2016-12-09 Thread Andrew Cooper
On 08/12/16 12:20, Jan Beulich wrote: > >> However, it would also require only enabling the SVM GP intercept in the >> hvm_update_guest_vendor() path (which should be renamed to something >> slightly more generic like hvm_cpuid_policy_updated()). > Why that? We always need it intercepted as long as

Re: [Xen-devel] [PATCH 2/3] x86/HVM: support (emulate) UMIP

2016-12-08 Thread Jan Beulich
>>> On 06.12.16 at 15:47, wrote: > As for UMIP itself, there are a number of issues which we should > consider here. > > First, this adds quite a lot of emulation and extra handling in security > sensitive areas. That isn't a problem per say, but given concerns with > emulation in general (and i

Re: [Xen-devel] [PATCH 2/3] x86/HVM: support (emulate) UMIP

2016-12-08 Thread Tian, Kevin
> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Thursday, December 08, 2016 12:07 AM > > On 07/12/16 15:39, Jan Beulich wrote: > On 07.12.16 at 16:31, wrote: > >> On 12/07/2016 10:14 AM, Jan Beulich wrote: > >> On 07.12.16 at 16:10, wrote: > On 12/07/2016 06:29 AM,

Re: [Xen-devel] [PATCH 2/3] x86/HVM: support (emulate) UMIP

2016-12-07 Thread Andrew Cooper
On 07/12/16 15:39, Jan Beulich wrote: On 07.12.16 at 16:31, wrote: >> On 12/07/2016 10:14 AM, Jan Beulich wrote: >> On 07.12.16 at 16:10, wrote: On 12/07/2016 06:29 AM, Jan Beulich wrote: On 06.12.16 at 17:23, wrote: >> On 12/06/2016 06:44 AM, Jan Beulich wrote: >>

Re: [Xen-devel] [PATCH 2/3] x86/HVM: support (emulate) UMIP

2016-12-07 Thread Jan Beulich
>>> On 07.12.16 at 16:31, wrote: > On 12/07/2016 10:14 AM, Jan Beulich wrote: > On 07.12.16 at 16:10, wrote: >>> On 12/07/2016 06:29 AM, Jan Beulich wrote: >>> On 06.12.16 at 17:23, wrote: > On 12/06/2016 06:44 AM, Jan Beulich wrote: >> --- a/xen/arch/x86/cpuid.c >> +++ b/xen

Re: [Xen-devel] [PATCH 2/3] x86/HVM: support (emulate) UMIP

2016-12-07 Thread Boris Ostrovsky
On 12/07/2016 10:14 AM, Jan Beulich wrote: On 07.12.16 at 16:10, wrote: >> On 12/07/2016 06:29 AM, Jan Beulich wrote: >> On 06.12.16 at 17:23, wrote: On 12/06/2016 06:44 AM, Jan Beulich wrote: > --- a/xen/arch/x86/cpuid.c > +++ b/xen/arch/x86/cpuid.c > @@ -154,6 +154,13

Re: [Xen-devel] [PATCH 2/3] x86/HVM: support (emulate) UMIP

2016-12-07 Thread Boris Ostrovsky
On 12/07/2016 06:29 AM, Jan Beulich wrote: On 06.12.16 at 17:23, wrote: >> On 12/06/2016 06:44 AM, Jan Beulich wrote: >>> --- a/xen/arch/x86/cpuid.c >>> +++ b/xen/arch/x86/cpuid.c >>> @@ -154,6 +154,13 @@ static void __init calculate_hvm_feature >>> __set_bit(X86_FEATURE_APIC, hvm_featur

Re: [Xen-devel] [PATCH 2/3] x86/HVM: support (emulate) UMIP

2016-12-07 Thread Jan Beulich
>>> On 07.12.16 at 16:10, wrote: > On 12/07/2016 06:29 AM, Jan Beulich wrote: > On 06.12.16 at 17:23, wrote: >>> On 12/06/2016 06:44 AM, Jan Beulich wrote: --- a/xen/arch/x86/cpuid.c +++ b/xen/arch/x86/cpuid.c @@ -154,6 +154,13 @@ static void __init calculate_hvm_feature

Re: [Xen-devel] [PATCH 2/3] x86/HVM: support (emulate) UMIP

2016-12-07 Thread Jan Beulich
>>> On 06.12.16 at 17:23, wrote: > On 12/06/2016 06:44 AM, Jan Beulich wrote: >> --- a/xen/arch/x86/cpuid.c >> +++ b/xen/arch/x86/cpuid.c >> @@ -154,6 +154,13 @@ static void __init calculate_hvm_feature >> __set_bit(X86_FEATURE_APIC, hvm_featureset); >> >> /* >> + * Xen can often p

Re: [Xen-devel] [PATCH 2/3] x86/HVM: support (emulate) UMIP

2016-12-06 Thread Boris Ostrovsky
On 12/06/2016 06:44 AM, Jan Beulich wrote: > There are three noteworthy drawbacks: > 1) The intercepts we need to enable here are CPL-independent, i.e. we >now have to emulate certain instructions for ring 0. > 2) On VMX there's no intercept for SMSW, so the emulation isn't really >complete

Re: [Xen-devel] [PATCH 2/3] x86/HVM: support (emulate) UMIP

2016-12-06 Thread Andrew Cooper
On 06/12/16 14:55, Jan Beulich wrote: On 06.12.16 at 15:47, wrote: >> On 06/12/16 11:44, Jan Beulich wrote: >>> This once again points out that handle_mmio() is rather badly named, as >>> it's about more than just MMIO. Since we have hvm_emulate_one() >>> already, I am, however, lacking an id

Re: [Xen-devel] [PATCH 2/3] x86/HVM: support (emulate) UMIP

2016-12-06 Thread Jan Beulich
>>> On 06.12.16 at 15:47, wrote: > On 06/12/16 11:44, Jan Beulich wrote: >> This once again points out that handle_mmio() is rather badly named, as >> it's about more than just MMIO. Since we have hvm_emulate_one() >> already, I am, however, lacking an idea for a good alternative name. > > As am

Re: [Xen-devel] [PATCH 2/3] x86/HVM: support (emulate) UMIP

2016-12-06 Thread Andrew Cooper
On 06/12/16 11:44, Jan Beulich wrote: > There are three noteworthy drawbacks: > 1) The intercepts we need to enable here are CPL-independent, i.e. we >now have to emulate certain instructions for ring 0. > 2) On VMX there's no intercept for SMSW, so the emulation isn't really >complete ther

[Xen-devel] [PATCH 2/3] x86/HVM: support (emulate) UMIP

2016-12-06 Thread Jan Beulich
There are three noteworthy drawbacks: 1) The intercepts we need to enable here are CPL-independent, i.e. we now have to emulate certain instructions for ring 0. 2) On VMX there's no intercept for SMSW, so the emulation isn't really complete there. 3) The CR4 write intercept on SVM is lower pr