Re: [Xen-devel] [PATCH 2/3] libxl: Domain destroy: unlock userdata earlier

2015-03-20 Thread Ian Campbell
On Wed, 2015-03-18 at 11:52 -0600, Jim Fehlig wrote: > Ian Campbell wrote: > > On Tue, 2015-03-17 at 17:34 +, Wei Liu wrote: > > > >> On Tue, Mar 17, 2015 at 09:30:58AM -0600, Jim Fehlig wrote: > >> > >>> From: Ian Jackson > >>> > >>> Unlock the userdata before we actually call xc_doma

Re: [Xen-devel] [PATCH 2/3] libxl: Domain destroy: unlock userdata earlier

2015-03-18 Thread Jim Fehlig
Ian Campbell wrote: > On Tue, 2015-03-17 at 17:34 +, Wei Liu wrote: > >> On Tue, Mar 17, 2015 at 09:30:58AM -0600, Jim Fehlig wrote: >> >>> From: Ian Jackson >>> >>> Unlock the userdata before we actually call xc_domain_destroy. This >>> leaves open the possibility that other libxl ca

Re: [Xen-devel] [PATCH 2/3] libxl: Domain destroy: unlock userdata earlier

2015-03-18 Thread Ian Campbell
On Tue, 2015-03-17 at 17:34 +, Wei Liu wrote: > On Tue, Mar 17, 2015 at 09:30:58AM -0600, Jim Fehlig wrote: > > From: Ian Jackson > > > > Unlock the userdata before we actually call xc_domain_destroy. This > > leaves open the possibility that other libxl callers will see the > > half-destroy

Re: [Xen-devel] [PATCH 2/3] libxl: Domain destroy: unlock userdata earlier

2015-03-17 Thread Wei Liu
On Tue, Mar 17, 2015 at 09:30:58AM -0600, Jim Fehlig wrote: > From: Ian Jackson > > Unlock the userdata before we actually call xc_domain_destroy. This > leaves open the possibility that other libxl callers will see the > half-destroyed domain (with no devices, paused), but this is fine. > > Si

[Xen-devel] [PATCH 2/3] libxl: Domain destroy: unlock userdata earlier

2015-03-17 Thread Jim Fehlig
From: Ian Jackson Unlock the userdata before we actually call xc_domain_destroy. This leaves open the possibility that other libxl callers will see the half-destroyed domain (with no devices, paused), but this is fine. Signed-off-by: Ian Jackson CC: Wei Liu Reviewed-by: Jim Fehlig Tested-by: