Wei Liu writes ("Re: [PATCH 3/4] libxl/remus: Change the assert for info to an
return"):
> On Tue, Jan 26, 2016 at 04:30:59PM -0500, Konrad Rzeszutek Wilk wrote:
> > The assert(info) is after quite a lot of manipulations
> > on 'info' - which makes the assert pointless because if
> > info was NULL
Ian Campbell writes ("Re: [PATCH 2/3] libxl/remus: Move the assert before the
info is used."):
> On Mon, 2016-01-25 at 16:06 -0500, Konrad Rzeszutek Wilk wrote:
> > The assert(info) is after quite a lot of manipulations
> > on 'info' - which makes the assert pointless because if
> > info was NULL
On Mon, 2016-01-25 at 16:06 -0500, Konrad Rzeszutek Wilk wrote:
> The assert(info) is after quite a lot of manipulations
> on 'info' - which makes the assert pointless because if
> info was NULL it would have crashed earlier.
>
> Move it earlier so that it guards before we try using
> the 'info' s
The assert(info) is after quite a lot of manipulations
on 'info' - which makes the assert pointless because if
info was NULL it would have crashed earlier.
Move it earlier so that it guards before we try using
the 'info' structure.
CC: Wen Congyang
CC: Yang Hongyang
Signed-off-by: Konrad Rzeszu
