Re: [Xen-devel] [PATCH 2/2] xsm: move FLASK_AVC_STATS to Kconfig

2016-03-19 Thread Doug Goldstein
On 3/14/16 9:05 AM, Doug Goldstein wrote: > On 3/8/16 12:01 PM, Daniel De Graaf wrote: >> On 03/08/2016 11:51 AM, Jan Beulich wrote: >> On 08.03.16 at 17:22, wrote: On 03/08/2016 04:46 AM, Jan Beulich wrote: On 07.03.16 at 19:42, wrote: >> Have Kconfig set CONFIG_FLASK_AVC_S

Re: [Xen-devel] [PATCH 2/2] xsm: move FLASK_AVC_STATS to Kconfig

2016-03-14 Thread Doug Goldstein
On 3/8/16 12:01 PM, Daniel De Graaf wrote: > On 03/08/2016 11:51 AM, Jan Beulich wrote: > On 08.03.16 at 17:22, wrote: >>> On 03/08/2016 04:46 AM, Jan Beulich wrote: >>> On 07.03.16 at 19:42, wrote: > Have Kconfig set CONFIG_FLASK_AVC_STATS and prefix all uses with > CONFIG_ >

Re: [Xen-devel] [PATCH 2/2] xsm: move FLASK_AVC_STATS to Kconfig

2016-03-08 Thread Daniel De Graaf
On 03/08/2016 11:51 AM, Jan Beulich wrote: On 08.03.16 at 17:22, wrote: On 03/08/2016 04:46 AM, Jan Beulich wrote: On 07.03.16 at 19:42, wrote: Have Kconfig set CONFIG_FLASK_AVC_STATS and prefix all uses with CONFIG_ to use the Kconfig variable. Same question here: What's the benefit of do

Re: [Xen-devel] [PATCH 2/2] xsm: move FLASK_AVC_STATS to Kconfig

2016-03-08 Thread Jan Beulich
>>> On 08.03.16 at 17:22, wrote: > On 03/08/2016 04:46 AM, Jan Beulich wrote: > On 07.03.16 at 19:42, wrote: >>> Have Kconfig set CONFIG_FLASK_AVC_STATS and prefix all uses with CONFIG_ >>> to use the Kconfig variable. >> >> Same question here: What's the benefit of doing it this way? > > Th

Re: [Xen-devel] [PATCH 2/2] xsm: move FLASK_AVC_STATS to Kconfig

2016-03-08 Thread Daniel De Graaf
On 03/08/2016 04:46 AM, Jan Beulich wrote: On 07.03.16 at 19:42, wrote: Have Kconfig set CONFIG_FLASK_AVC_STATS and prefix all uses with CONFIG_ to use the Kconfig variable. Same question here: What's the benefit of doing it this way? This removes the stats tracking, which might (I have not

Re: [Xen-devel] [PATCH 2/2] xsm: move FLASK_AVC_STATS to Kconfig

2016-03-08 Thread Jan Beulich
>>> On 07.03.16 at 19:42, wrote: > Have Kconfig set CONFIG_FLASK_AVC_STATS and prefix all uses with CONFIG_ > to use the Kconfig variable. Same question here: What's the benefit of doing it this way? > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -23,6 +23,12 @@ config FLASK > >

[Xen-devel] [PATCH 2/2] xsm: move FLASK_AVC_STATS to Kconfig

2016-03-07 Thread Doug Goldstein
Have Kconfig set CONFIG_FLASK_AVC_STATS and prefix all uses with CONFIG_ to use the Kconfig variable. Signed-off-by: Doug Goldstein --- CC: Daniel De Graaf --- xen/common/Kconfig | 8 +++- xen/include/xen/config.h| 5 - xen/xsm/flask/avc.c | 4 ++-- xen/xsm/flask/fl