Re: [Xen-devel] [PATCH 2/2] xl: split out vnc and console related code

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 2/2] xl: split out vnc and console related code"): > The new file also contains code for channel, which is just a console > in disguise. Good. Except that... > Replace the call to vncviewer() with libxl_vncviewer_exec() directly in > main_vncviewer. ... you forgot to rem

[Xen-devel] [PATCH 2/2] xl: split out vnc and console related code

2017-02-27 Thread Wei Liu
The new file also contains code for channel, which is just a console in disguise. Replace the call to vncviewer() with libxl_vncviewer_exec() directly in main_vncviewer. Signed-off-by: Wei Liu --- tools/xl/Makefile | 2 +- tools/xl/xl_cmdimpl.c | 99 --