On 17/08/2015 11:58, Chris (Christopher) Brand wrote:
Hi Julien,
Thanks for the review.
+.pxn = 0,
I would add a comment to explain that this bit is reserved for PL2 stage
1 page table.
Will do.
+.avail = 0,
I don't think this one is necessary. avail is not us
Hi Julien,
Thanks for the review.
> > +.pxn = 0,
>
> I would add a comment to explain that this bit is reserved for PL2 stage
> 1 page table.
Will do.
> > +.avail = 0,
>
> I don't think this one is necessary. avail is not used by the hardware neither
> Xen.
"grep -rF
Hi Chris,
On 14/08/2015 14:42, Chris (Christopher) Brand wrote:
Ensure that every bit has a specific value.
Reported-by: Julien Grall
Signed-off-by: Chris Brand
---
xen/include/asm-arm/page.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/xen/include/asm-arm/page.h b/xen/include/
Ensure that every bit has a specific value.
Reported-by: Julien Grall
Signed-off-by: Chris Brand
---
xen/include/asm-arm/page.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/xen/include/asm-arm/page.h b/xen/include/asm-arm/page.h
index 01628f3e96cb..7a56b2cb463a 100644
--- a/xen/incl
