Re: [Xen-devel] [PATCH 2/2] xen/pt: Avoid NULL dereference in hvm_pirq_eoi()

2017-06-28 Thread Roger Pau Monné
On Tue, Jun 27, 2017 at 06:47:53PM +0100, Andrew Cooper wrote: > Coverity warns that pirq_dpci unconditionally dereferences a NULL pointer. > This warning appears to be triggered by pirq_dpci() which is a hidden ternary > expression. In reality, it appears that both callers pass a non-NULL pirq >

Re: [Xen-devel] [PATCH 2/2] xen/pt: Avoid NULL dereference in hvm_pirq_eoi()

2017-06-27 Thread Jan Beulich
>>> Andrew Cooper 06/27/17 7:48 PM >>> >Coverity warns that pirq_dpci unconditionally dereferences a NULL pointer. >This warning appears to be triggered by pirq_dpci() which is a hidden ternary >expression. In reality, it appears that both callers pass a non-NULL pirq >parameter, so the code is o

[Xen-devel] [PATCH 2/2] xen/pt: Avoid NULL dereference in hvm_pirq_eoi()

2017-06-27 Thread Andrew Cooper
Coverity warns that pirq_dpci unconditionally dereferences a NULL pointer. This warning appears to be triggered by pirq_dpci() which is a hidden ternary expression. In reality, it appears that both callers pass a non-NULL pirq parameter, so the code is ok in practice. Rearange the logic to fail-s