Re: [Xen-devel] [PATCH 2/2] xen/arm64: use shift operator

2016-04-23 Thread Peng Fan
Hi Julien, On Fri, Apr 22, 2016 at 05:08:26PM +0100, Julien Grall wrote: >On 21/04/16 02:06, Peng Fan wrote: >>Hi Julien, > >Hello Peng, > >>On Wed, Apr 20, 2016 at 03:44:09PM +0100, Julien Grall wrote: >>>Hello Peng, >>> >>>On 20/04/16 14:54, Peng Fan wrote: Use shift operator, but not mulipli

Re: [Xen-devel] [PATCH 2/2] xen/arm64: use shift operator

2016-04-22 Thread Julien Grall
On 21/04/16 02:06, Peng Fan wrote: Hi Julien, Hello Peng, On Wed, Apr 20, 2016 at 03:44:09PM +0100, Julien Grall wrote: Hello Peng, On 20/04/16 14:54, Peng Fan wrote: Use shift operator, but not muliplication. No function change. Why? The compiler will calculate the address at compilatio

Re: [Xen-devel] [PATCH 2/2] xen/arm64: use shift operator

2016-04-20 Thread Peng Fan
Hi Julien, On Wed, Apr 20, 2016 at 03:44:09PM +0100, Julien Grall wrote: >Hello Peng, > >On 20/04/16 14:54, Peng Fan wrote: >>Use shift operator, but not muliplication. >>No function change. > >Why? The compiler will calculate the address at compilation time. Yeah. The compiler will do this. I ju

Re: [Xen-devel] [PATCH 2/2] xen/arm64: use shift operator

2016-04-20 Thread Julien Grall
Hello Peng, On 20/04/16 14:54, Peng Fan wrote: Use shift operator, but not muliplication. No function change. Why? The compiler will calculate the address at compilation time. Regards, Signed-off-by: Peng Fan Cc: Stefano Stabellini Cc: Julien Grall --- xen/arch/arm/arm64/head.S | 2 +-

[Xen-devel] [PATCH 2/2] xen/arm64: use shift operator

2016-04-20 Thread Peng Fan
Use shift operator, but not muliplication. No function change. Signed-off-by: Peng Fan Cc: Stefano Stabellini Cc: Julien Grall --- xen/arch/arm/arm64/head.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index 05e3db0..