Re: [Xen-devel] [PATCH 2/2] x86emul: support LAR/LSL/VERR/VERW

2016-12-09 Thread Jan Beulich
>>> On 08.12.16 at 17:24, wrote: > On 08/12/16 11:52, Jan Beulich wrote: >> @@ -1401,14 +1401,11 @@ protmode_load_seg( >> return rc; >> } >> >> -if ( !is_x86_user_segment(seg) ) >> -{ >> -/* System segments must have S flag == 0. */ >> -if ( desc.b & (1u <<

Re: [Xen-devel] [PATCH 2/2] x86emul: support LAR/LSL/VERR/VERW

2016-12-08 Thread Andrew Cooper
On 08/12/16 11:52, Jan Beulich wrote: > --- a/xen/arch/x86/x86_emulate/x86_emulate.c > +++ b/xen/arch/x86/x86_emulate/x86_emulate.c > @@ -182,7 +182,7 @@ static const opcode_desc_t opcode_table[ > > static const opcode_desc_t twobyte_table[256] = { > /* 0x00 - 0x07 */ > -ModRM, Implicit

[Xen-devel] [PATCH 2/2] x86emul: support LAR/LSL/VERR/VERW

2016-12-08 Thread Jan Beulich
Signed-off-by: Jan Beulich --- a/tools/tests/x86_emulator/test_x86_emulator.c +++ b/tools/tests/x86_emulator/test_x86_emulator.c @@ -46,7 +46,47 @@ static int read( if ( verbose ) printf("** %s(%u, %p,, %u,)\n", __func__, seg, (void *)offset, bytes); -bytes_read += bytes; +