Re: [Xen-devel] [PATCH 2/2] x86/tboot: simplify DMAR table copying

2015-03-04 Thread Wei, Gang
OnĀ Feb 18, 2015 17:03, Jan Beulich wrote: > There's no need for more than one variable, no need for casts, and no > point in using the type-safe xmalloc_array() here. > > Signed-off-by: Jan Beulich > > --- a/xen/arch/x86/tboot.c > +++ b/xen/arch/x86/tboot.c > @@ -435,13 +435,12 @@ int __init tb

Re: [Xen-devel] [PATCH 2/2] x86/tboot: simplify DMAR table copying

2015-02-18 Thread Andrew Cooper
On 18/02/15 09:03, Jan Beulich wrote: > There's no need for more than one variable, no need for casts, and no > point in using the type-safe xmalloc_array() here. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper > > --- a/xen/arch/x86/tboot.c > +++ b/xen/arch/x86/tboot.c > @@ -435,13 +

[Xen-devel] [PATCH 2/2] x86/tboot: simplify DMAR table copying

2015-02-18 Thread Jan Beulich
There's no need for more than one variable, no need for casts, and no point in using the type-safe xmalloc_array() here. Signed-off-by: Jan Beulich --- a/xen/arch/x86/tboot.c +++ b/xen/arch/x86/tboot.c @@ -435,13 +435,12 @@ int __init tboot_protect_mem_regions(voi int __init tboot_parse_dmar_