Re: [Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level

2016-04-06 Thread Ian Jackson
George Dunlap writes ("Re: [Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level"): > On Wed, Apr 6, 2016 at 3:07 PM, Ian Jackson wrote: > > Doug, would you like to, for now, propose a patch that uses -Og if it > > is available, but otherwise falls

Re: [Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level

2016-04-06 Thread George Dunlap
On Wed, Apr 6, 2016 at 3:07 PM, Ian Jackson wrote: > Doug Goldstein writes ("[PATCH 2/2] tools: detect appropriate debug > optimization level"): >> The build should not use -O0 as that results in miscompilations. There >> have been a few instances on the ML where users were told to switch >> from

Re: [Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level

2016-04-06 Thread Ian Jackson
Doug Goldstein writes ("[PATCH 2/2] tools: detect appropriate debug optimization level"): > The build should not use -O0 as that results in miscompilations. There > have been a few instances on the ML where users were told to switch > from -O0 to -O1 or -O2 or to set debug=n and their issue went a

Re: [Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level

2016-03-31 Thread George Dunlap
On Wed, Mar 30, 2016 at 5:00 PM, Ian Jackson wrote: > Doug Goldstein writes ("Re: [PATCH 2/2] tools: detect appropriate debug > optimization level"): >> On 3/8/16 9:38 AM, Wei Liu wrote: >> > On Mon, Mar 07, 2016 at 08:23:40PM -0600, Doug Goldstein wrote: >> >> The build should not use -O0 as tha

Re: [Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level

2016-03-30 Thread Ian Jackson
Ian Jackson writes ("Re: [PATCH 2/2] tools: detect appropriate debug optimization level"): > My initial reaction is that I any actual problems are bugs either in > the compiler or in Xen, which should be fixed. > > There should be nothing wrong with lack of inlining or dead code > elimination. I

Re: [Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level

2016-03-30 Thread Doug Goldstein
On 3/30/16 11:00 AM, Ian Jackson wrote: > Doug Goldstein writes ("Re: [PATCH 2/2] tools: detect appropriate debug > optimization level"): >> On 3/8/16 9:38 AM, Wei Liu wrote: >>> On Mon, Mar 07, 2016 at 08:23:40PM -0600, Doug Goldstein wrote: The build should not use -O0 as that results in mi

Re: [Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level

2016-03-30 Thread Ian Jackson
Doug Goldstein writes ("Re: [PATCH 2/2] tools: detect appropriate debug optimization level"): > On 3/8/16 9:38 AM, Wei Liu wrote: > > On Mon, Mar 07, 2016 at 08:23:40PM -0600, Doug Goldstein wrote: > >> The build should not use -O0 as that results in miscompilations. There > > > > This needs some

Re: [Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level

2016-03-30 Thread George Dunlap
On Tue, Mar 29, 2016 at 6:21 PM, Doug Goldstein wrote: > On 3/29/16 6:44 AM, George Dunlap wrote: >> On Mon, Mar 28, 2016 at 4:01 PM, Doug Goldstein wrote: >>> On 3/16/16 2:14 PM, Doug Goldstein wrote: On 3/8/16 10:50 AM, Wei Liu wrote: > On Tue, Mar 08, 2016 at 10:34:42AM -0600, Doug Go

Re: [Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level

2016-03-29 Thread Doug Goldstein
On 3/29/16 6:44 AM, George Dunlap wrote: > On Mon, Mar 28, 2016 at 4:01 PM, Doug Goldstein wrote: >> On 3/16/16 2:14 PM, Doug Goldstein wrote: >>> On 3/8/16 10:50 AM, Wei Liu wrote: On Tue, Mar 08, 2016 at 10:34:42AM -0600, Doug Goldstein wrote: > On 3/8/16 9:38 AM, Wei Liu wrote: >>

Re: [Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level

2016-03-29 Thread George Dunlap
On Mon, Mar 28, 2016 at 4:01 PM, Doug Goldstein wrote: > On 3/16/16 2:14 PM, Doug Goldstein wrote: >> On 3/8/16 10:50 AM, Wei Liu wrote: >>> On Tue, Mar 08, 2016 at 10:34:42AM -0600, Doug Goldstein wrote: On 3/8/16 9:38 AM, Wei Liu wrote: > On Mon, Mar 07, 2016 at 08:23:40PM -0600, Doug G

Re: [Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level

2016-03-28 Thread Doug Goldstein
On 3/16/16 2:14 PM, Doug Goldstein wrote: > On 3/8/16 10:50 AM, Wei Liu wrote: >> On Tue, Mar 08, 2016 at 10:34:42AM -0600, Doug Goldstein wrote: >>> On 3/8/16 9:38 AM, Wei Liu wrote: On Mon, Mar 07, 2016 at 08:23:40PM -0600, Doug Goldstein wrote: > The build should not use -O0 as that res

Re: [Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level

2016-03-19 Thread Doug Goldstein
On 3/8/16 10:50 AM, Wei Liu wrote: > On Tue, Mar 08, 2016 at 10:34:42AM -0600, Doug Goldstein wrote: >> On 3/8/16 9:38 AM, Wei Liu wrote: >>> On Mon, Mar 07, 2016 at 08:23:40PM -0600, Doug Goldstein wrote: The build should not use -O0 as that results in miscompilations. There >>> >>> This need

Re: [Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level

2016-03-08 Thread Wei Liu
On Tue, Mar 08, 2016 at 10:34:42AM -0600, Doug Goldstein wrote: > On 3/8/16 9:38 AM, Wei Liu wrote: > > On Mon, Mar 07, 2016 at 08:23:40PM -0600, Doug Goldstein wrote: > >> The build should not use -O0 as that results in miscompilations. There > > > > This needs some (concrete) references. Is that

Re: [Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level

2016-03-08 Thread Doug Goldstein
On 3/8/16 9:38 AM, Wei Liu wrote: > On Mon, Mar 07, 2016 at 08:23:40PM -0600, Doug Goldstein wrote: >> The build should not use -O0 as that results in miscompilations. There > > This needs some (concrete) references. Is that a known issue in gcc? If > so can you reference the bug number? So its n

Re: [Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level

2016-03-08 Thread Wei Liu
On Mon, Mar 07, 2016 at 08:23:40PM -0600, Doug Goldstein wrote: > The build should not use -O0 as that results in miscompilations. There This needs some (concrete) references. Is that a known issue in gcc? If so can you reference the bug number? > have been a few instances on the ML where users w

[Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level

2016-03-07 Thread Doug Goldstein
The build should not use -O0 as that results in miscompilations. There have been a few instances on the ML where users were told to switch from -O0 to -O1 or -O2 or to set debug=n and their issue went away. The preferred route should be to use -Og if its available, otherwise use -O1 which is the de