Re: [Xen-devel] [PATCH 2/2] oxenstored: honour XEN_LOG_DIR defined by configure

2016-06-12 Thread Wei Liu
On Fri, Jun 10, 2016 at 09:26:05PM +0100, David Scott wrote: > Hi, > > Rather than > > (String.concat “” [a; b]) > > it’s simpler to write > > (a ^ b) > > With that small change, > Indeed, this looks better. I will update the patch accordingly. > Acked-by: David Scott Thanks! Wei. _

Re: [Xen-devel] [PATCH 2/2] oxenstored: honour XEN_LOG_DIR defined by configure

2016-06-10 Thread David Scott
Hi, Rather than (String.concat “” [a; b]) it’s simpler to write (a ^ b) With that small change, Acked-by: David Scott Cheers, Dave > On 10 Jun 2016, at 19:44, Wei Liu wrote: > > CC Dave's correct email address. > > On Fri, Jun 10, 2016 at 03:25:46PM +0100, Wei Liu wrote: >> We gener

Re: [Xen-devel] [PATCH 2/2] oxenstored: honour XEN_LOG_DIR defined by configure

2016-06-10 Thread Wei Liu
CC Dave's correct email address. On Fri, Jun 10, 2016 at 03:25:46PM +0100, Wei Liu wrote: > We generate a corresponding constant (in lower case) in paths.ml. Use > that in source code to get rid of hard-coded path. > > Signed-off-by: Wei Liu > --- > Cc: Ian Jackson > Cc: David Scot > --- > to

[Xen-devel] [PATCH 2/2] oxenstored: honour XEN_LOG_DIR defined by configure

2016-06-10 Thread Wei Liu
We generate a corresponding constant (in lower case) in paths.ml. Use that in source code to get rid of hard-coded path. Signed-off-by: Wei Liu --- Cc: Ian Jackson Cc: David Scot --- tools/ocaml/xenstored/logging.ml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/