Re: [Xen-devel] [PATCH 2/2] nested vmx: Validate host VMX MSRs before accessing them

2016-06-12 Thread Tian, Kevin
> From: Euan Harris [mailto:euan.har...@citrix.com] > Sent: Thursday, June 09, 2016 9:21 PM > > On Thu, Jun 09, 2016 at 06:47:55AM -0600, Jan Beulich wrote: > > > /* > > > - * Those MSRs are available only when bit 55 of > > > - * MSR_IA32_VMX_BASIC is set. > > > + * These MSRs ar

Re: [Xen-devel] [PATCH 2/2] nested vmx: Validate host VMX MSRs before accessing them

2016-06-09 Thread Euan Harris
On Thu, Jun 09, 2016 at 06:47:55AM -0600, Jan Beulich wrote: > > /* > > - * Those MSRs are available only when bit 55 of > > - * MSR_IA32_VMX_BASIC is set. > > + * These MSRs are only available when flags in other MSRs are set. > > + * These prerequisites are listed in the Inte

Re: [Xen-devel] [PATCH 2/2] nested vmx: Validate host VMX MSRs before accessing them

2016-06-09 Thread Jan Beulich
>>> On 09.06.16 at 12:14, wrote: > --- a/xen/arch/x86/hvm/vmx/vvmx.c > +++ b/xen/arch/x86/hvm/vmx/vvmx.c > @@ -1820,11 +1820,20 @@ int nvmx_msr_read_intercept(unsigned int msr, u64 > *msr_content) > return 0; > > /* > - * Those MSRs are available only when bit 55 of > - *

[Xen-devel] [PATCH 2/2] nested vmx: Validate host VMX MSRs before accessing them

2016-06-09 Thread Euan Harris
Some VMX MSRs may not exist on certain processor models, or may be disabled because of configuration settings. It is only safe to access these MSRs if configuration flags in other MSRs are set. These prerequisites are listed in the Intel 64 and IA-32 Architectures Software Developer’s Manual, Vo