Re: [Xen-devel] [PATCH 2/2] libxl: fix osvm cpuid flag

2017-06-28 Thread Andrew Cooper
On 28/06/17 18:51, Wei Liu wrote: > On Wed, Jun 28, 2017 at 05:20:38PM +0100, Andrew Cooper wrote: >> On 28/06/17 17:14, Marek Marczykowski-Górecki wrote: >>> On Wed, Jun 28, 2017 at 11:16:33AM +0100, Andrew Cooper wrote: On 28/06/17 07:09, Jan Beulich wrote: Marek Marczykowski-Góreck

Re: [Xen-devel] [PATCH 2/2] libxl: fix osvm cpuid flag

2017-06-28 Thread Wei Liu
On Wed, Jun 28, 2017 at 05:20:38PM +0100, Andrew Cooper wrote: > On 28/06/17 17:14, Marek Marczykowski-Górecki wrote: > > On Wed, Jun 28, 2017 at 11:16:33AM +0100, Andrew Cooper wrote: > >> On 28/06/17 07:09, Jan Beulich wrote: > >> Marek Marczykowski-Górecki 06/28/17 > >> 3:09 AM >>> > >

Re: [Xen-devel] [PATCH 2/2] libxl: fix osvm cpuid flag

2017-06-28 Thread Andrew Cooper
On 28/06/17 17:14, Marek Marczykowski-Górecki wrote: > On Wed, Jun 28, 2017 at 11:16:33AM +0100, Andrew Cooper wrote: >> On 28/06/17 07:09, Jan Beulich wrote: >> Marek Marczykowski-Górecki 06/28/17 >> 3:09 AM >>> It's bit 9 not 10 (which is ibs). >>> Indeed, but shouldn't it rather b

Re: [Xen-devel] [PATCH 2/2] libxl: fix osvm cpuid flag

2017-06-28 Thread Marek Marczykowski-Górecki
On Wed, Jun 28, 2017 at 11:16:33AM +0100, Andrew Cooper wrote: > On 28/06/17 07:09, Jan Beulich wrote: > Marek Marczykowski-Górecki 06/28/17 > 3:09 AM >>> > >> It's bit 9 not 10 (which is ibs). > > Indeed, but shouldn't it rather be removed? We don't expose it from the > > hypervisor at

Re: [Xen-devel] [PATCH 2/2] libxl: fix osvm cpuid flag

2017-06-28 Thread Andrew Cooper
On 28/06/17 07:09, Jan Beulich wrote: Marek Marczykowski-Górecki 06/28/17 3:09 AM >>> >> It's bit 9 not 10 (which is ibs). > Indeed, but shouldn't it rather be removed? We don't expose it from the > hypervisor at all anymore: > > XEN_CPUFEATURE(OSVW, 3*32+ 9) /* OS Visible Wo

Re: [Xen-devel] [PATCH 2/2] libxl: fix osvm cpuid flag

2017-06-27 Thread Jan Beulich
>>> Marek Marczykowski-Górecki 06/28/17 3:09 >>> AM >>> >It's bit 9 not 10 (which is ibs). Indeed, but shouldn't it rather be removed? We don't expose it from the hypervisor at all anymore: XEN_CPUFEATURE(OSVW, 3*32+ 9) /* OS Visible Workaround */ (note the absence of any marker cha

[Xen-devel] [PATCH 2/2] libxl: fix osvm cpuid flag

2017-06-27 Thread Marek Marczykowski-Górecki
It's bit 9 not 10 (which is ibs). Signed-off-by: Marek Marczykowski-Górecki --- tools/libxl/libxl_cpuid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/libxl_cpuid.c b/tools/libxl/libxl_cpuid.c index 1cf7973..a4a69af 100644 --- a/tools/libxl/libxl_cpuid.c +++ b/