Re: [Xen-devel] [PATCH 2/2] libxl/devd: prevent adding spurious domains to the list

2017-05-11 Thread Wei Liu
On Thu, May 11, 2017 at 09:24:40AM +0100, Roger Pau Monne wrote: > On Wed, May 10, 2017 at 05:29:12PM +0100, Wei Liu wrote: > > On Wed, May 10, 2017 at 11:12:39AM +0100, Roger Pau Monne wrote: > > > Current code in backend_watch_callback forgets to remove a > > > libxl__ddomain_guest > > > from th

Re: [Xen-devel] [PATCH 2/2] libxl/devd: prevent adding spurious domains to the list

2017-05-11 Thread Roger Pau Monne
On Wed, May 10, 2017 at 05:29:12PM +0100, Wei Liu wrote: > On Wed, May 10, 2017 at 11:12:39AM +0100, Roger Pau Monne wrote: > > Current code in backend_watch_callback forgets to remove a > > libxl__ddomain_guest > > from the list of tracked domains when the related data is freed, causing > > deref

Re: [Xen-devel] [PATCH 2/2] libxl/devd: prevent adding spurious domains to the list

2017-05-10 Thread Wei Liu
On Wed, May 10, 2017 at 11:12:39AM +0100, Roger Pau Monne wrote: > Current code in backend_watch_callback forgets to remove a > libxl__ddomain_guest > from the list of tracked domains when the related data is freed, causing > dereferences later on when the list is traversed. Make sure that a domai

[Xen-devel] [PATCH 2/2] libxl/devd: prevent adding spurious domains to the list

2017-05-10 Thread Roger Pau Monne
Current code in backend_watch_callback forgets to remove a libxl__ddomain_guest from the list of tracked domains when the related data is freed, causing dereferences later on when the list is traversed. Make sure that a domain is always removed from the list when freed. Signed-off-by: Roger Pau Mo